Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add plugin support #230
feat: add plugin support #230
Changes from 12 commits
5616413
4b48be5
51130b0
3410510
2499417
e1ba06b
3937b01
5438066
f6b4e7c
429e3b1
ed5dce8
99104d4
0dbb7f6
454f85f
5bc7070
36aab7b
6ef48aa
0bd2eb9
18f7906
5b7ccc0
8f8c587
764eda2
de523ac
81b5ab9
8fa4104
0cdeace
6fd5837
f1e31a3
392d336
370a396
409ec2f
abcce27
6108cda
5dc9130
38db5e8
fb1ca4b
d3e2891
a2ce288
f6afac1
50a9e26
8b718e3
51d5136
87f7a7f
6b0eaa5
2f26925
bd2c537
38db1a9
1317545
e96287a
b0b1050
2a5cb18
0e5253d
20f69c2
e2b0937
97eeefe
f8a1366
56ab206
080ea92
f17244a
ec6cc7b
02f132d
c446cb1
a34cb65
e846c9c
2c78dfd
bdf62f7
87e9183
8698be5
c3615e0
9de03d2
af6385c
6a981a8
a6cf258
2ddc1cd
a1f2d67
ca88300
d140c9a
92db2b5
97f9bdd
d48a901
690eb1b
5720a9a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
h
: I feel like this is not config-cache compatible, so we'd have to useValueSource
and do something like this: https://github.com/getsentry/sentry-android-gradle-plugin/blob/f9b82ddce3af1a21eec54da8b1c02e36c063939a/plugin-build/src/main/kotlin/io/sentry/android/gradle/telemetry/SentryTelemetryService.kt#L527-L561There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added fetching the derived data path as a value source