-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: remove some dead code from plugins #83581
Conversation
dfe98f8
to
8b99d37
Compare
8b99d37
to
9704532
Compare
❌ 2 Tests Failed:
View the top 1 failed tests by shortest run time
View the full list of 1 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
introduced in several commits but never called
last reference removed in 70416f0
last reference removed in 74674b3
last reference removed in fbb1f06
introduced in 447f1e3 never referenced
introduced in 26c0d15 and never referenced
introduced in 26c0d15 but never used
this was always "unknown" so not useful
last reference removed in fbb1f06
last reference removed in d2102d3
introduced in b19aa76 but never used
last reference removed in 832ee5b
last reference removed in 70416f0
last reference removed in 5c93fc1
last reference removed in 5c93fc1
last reference removed in 367a687
last reference removed in 1c1aaeb
9704532
to
f4ba954
Compare
@@ -67,7 +67,6 @@ def serialize(self, obj, attrs, user, **kwargs): | |||
"hasConfiguration": obj.has_project_conf(), | |||
"metadata": obj.get_metadata(), | |||
"contexts": contexts, | |||
"status": obj.get_status(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there some associated frontend type change or anything for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to find one but I don't think our frontend actually loads or uses this at all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I absolutely cannot believe we even have a redmine plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't look at every signle line, but I trust how thourough this is given how you've written each commit. Thank you for doing this Anthony!
found via https://github.com/asottile/dead
each individual commit shows when the function was last called