ref: remove some dead code from plugins

src/sentry/api/serializers/models/plugin.py

@@ -67,7 +67,6 @@ def serialize(self, obj, attrs, user, **kwargs):
             "hasConfiguration": obj.has_project_conf(),
             "metadata": obj.get_metadata(),
             "contexts": contexts,
-            "status": obj.get_status(),
             "doc": doc,
             "firstPartyAlternative": getattr(obj, "alternative", None),
             "deprecationDate": (

src/sentry/integrations/jira/client.py

@@ -161,11 +161,6 @@ def get_versions(self, project):
     def get_priorities(self):
         return self.get_cached(self.PRIORITIES_URL)
 
-    def get_users_for_project(self, project):
-        # Jira Server wants a project key, while cloud is indifferent.
-        project_key = self.get_project_key_for_id(project)
-        return self.get_cached(self.USERS_URL, params={"project": project_key})
-
     def search_users_for_project(self, project, username):
         # Jira Server wants a project key, while cloud is indifferent.
         project_key = self.get_project_key_for_id(project)

src/sentry/integrations/jira_server/client.py

@@ -159,11 +159,6 @@ def get_priorities(self):
         """
         return self.get_cached(self.PRIORITIES_URL)
 
-    def get_users_for_project(self, project):
-        # Jira Server wants a project key, while cloud is indifferent.
-        project_key = self.get_project_key_for_id(project)
-        return self.get_cached(self.USERS_URL, params={"project": project_key})
-
     def search_users_for_project(self, project, username):
         # Jira Server wants a project key, while cloud is indifferent.
         project_key = self.get_project_key_for_id(project)

src/sentry/plugins/base/manager.py

@@ -61,12 +61,6 @@ def for_project(self, project, version=1):
                 continue
             yield plugin
 
-    def for_site(self, version=1):
-        for plugin in self.all(version=version):
-            if not plugin.has_site_conf():
-                continue
-            yield plugin
-
     def get(self, slug):
         for plugin in self.all(version=None):
             if plugin.slug == slug:

src/sentry/plugins/base/v1.py

@@ -14,7 +14,6 @@
 from sentry.plugins.base.response import DeferredResponse
 from sentry.plugins.base.view import PluggableViewMixin
 from sentry.plugins.config import PluginConfigMixin
-from sentry.plugins.status import PluginStatusMixin
 from sentry.projects.services.project import RpcProject
 
 if TYPE_CHECKING:
@@ -37,7 +36,7 @@ def __new__(cls, name, bases, attrs):
         return new_cls
 
 
-class IPlugin(local, PluggableViewMixin, PluginConfigMixin, PluginStatusMixin):
+class IPlugin(local, PluggableViewMixin, PluginConfigMixin):
     """
     Plugin interface. Should not be inherited from directly.
 
@@ -70,10 +69,6 @@ class IPlugin(local, PluggableViewMixin, PluginConfigMixin, PluginStatusMixin):
     conf_title: str | _StrPromise | None = None
 
     project_conf_form: Any = None
-    project_conf_template = "sentry/plugins/project_configuration.html"
-
-    site_conf_form: Any = None
-    site_conf_template = "sentry/plugins/site_configuration.html"
 
     # Global enabled state
     enabled = True
@@ -184,44 +179,15 @@ def get_conf_key(self):
             return self.get_conf_title().lower().replace(" ", "_")
         return self.conf_key
 
-    def get_conf_form(self, project=None):
-        """
-        Returns the Form required to configure the plugin.
-
-        >>> plugin.get_conf_form(project)
-        """
-        if project is not None:
-            return self.project_conf_form
-        return self.site_conf_form
-
-    def get_conf_template(self, project=None):
-        """
-        Returns the template required to render the configuration page.
-
-        >>> plugin.get_conf_template(project)
-        """
-        if project is not None:
-            return self.project_conf_template
-        return self.site_conf_template
-
     def get_conf_title(self):
         """
         Returns a string representing the title to be shown on the configuration page.
         """
         return self.conf_title or self.get_title()
 
-    def has_site_conf(self):
-        return self.site_conf_form is not None
-
     def has_project_conf(self):
         return self.project_conf_form is not None
 
-    def has_plugin_conf(self):
-        """
-        Checks if the plugin should be returned in the ProjectPluginsEndpoint
-        """
-        return self.has_project_conf()
-
     def can_enable_for_projects(self):
         """
         Returns a boolean describing whether this plugin can be enabled for
@@ -249,9 +215,6 @@ def can_configure_for_project(self, project):
 
         return True
 
-    def get_form_initial(self, project=None):
-        return {}
-
     # The following methods are specific to web requests
 
     def get_title(self) -> str | _StrPromise:
@@ -273,19 +236,6 @@ def get_description(self) -> str | None:
         """
         return self.description
 
-    def get_resource_links(self) -> Sequence[tuple[str, str]]:
-        """
-        Returns a list of tuples pointing to various resources for this plugin.
-
-        >>> def get_resource_links(self):
-        >>>     return [
-        >>>         ('Documentation', 'https://docs.sentry.io'),
-        >>>         ('Report Issue', 'https://github.com/getsentry/sentry/issues'),
-        >>>         ('View Source', 'https://github.com/getsentry/sentry'),
-        >>>     ]
-        """
-        return self.resource_links
-
     def get_view_response(self, request, group):
         self.selected = request.path == self.get_url(group)
 
@@ -329,25 +279,6 @@ def view(self, request, group, **kwargs):
         >>>     return self.render('myplugin/about.html')
         """
 
-    def before_events(self, request, group_list, **kwargs):
-        """
-        Allows preprocessing of groups in the list view.
-
-        This is generally useful if you need to cache lookups
-        for something like ``tags`` which would otherwise do
-        multiple queries.
-
-        If you use this **at all** you should ensure it's already
-        reset on each execution.
-
-        As an example, here's how we might get a reference to ticket ids we were
-        storing per event, in an efficient O(1) manner.
-
-        >>> def before_events(self, request, event_list, **kwargs):
-        >>>     prefix = self.get_conf_key()
-        >>>     GroupMeta.objects.get_value_bulk(event_list, '%s:tid' % prefix)
-        """
-
     def tags(self, request, group, tag_list, **kwargs):
         """
         Modifies the tag list for a grouped message.
@@ -379,22 +310,6 @@ def actions(self, request, group, action_list, **kwargs):
         """
         return action_list
 
-    def panels(self, request, group, panel_list, **kwargs):
-        """
-        Modifies the panel list for a grouped message.
-
-        A panel is a tuple containing two elements:
-
-        ('Panel Label', '/uri/to/panel/')
-
-        This must return ``panel_list``.
-
-        >>> def panels(self, request, group, action_list, **kwargs):
-        >>>     panel_list.append((self.get_title(), self.get_url(group)))
-        >>>     return panel_list
-        """
-        return panel_list
-
     def widget(self, request, group, **kwargs):
         """
         Renders as a widget in the group details sidebar.
@@ -405,14 +320,6 @@ def widget(self, request, group, **kwargs):
 
     # Server side signals which do not have request context
 
-    def has_perm(self, user, perm, *objects, **kwargs):
-        # DEPRECATED: No longer used.
-        pass
-
-    def missing_perm_response(self, request, perm, *args, **objects):
-        # DEPRECATED: No longer used.
-        pass
-
     def is_regression(self, group, event, **kwargs):
         """
         Called on new events when the group's status is resolved.
@@ -452,17 +359,6 @@ def get_tags(self, event, **kwargs):
         >>>     return [('tag-name', 'tag-value')]
         """
 
-    def get_notification_forms(self, **kwargs):
-        """
-        Provides additional UserOption forms for the Notification Settings page.
-
-        Must return an iterable.
-
-        >>> def get_notification_forms(self, **kwargs):
-        >>>     return [MySettingsForm]
-        """
-        return []
-
     def is_testable(self, **kwargs):
         """
         Returns True if this plugin is able to be tested.

src/sentry/plugins/base/v2.py

@@ -11,7 +11,6 @@
 from sentry.plugins.base.response import DeferredResponse
 from sentry.plugins.config import PluginConfigMixin
 from sentry.plugins.interfaces.releasehook import ReleaseHook
-from sentry.plugins.status import PluginStatusMixin
 
 if TYPE_CHECKING:
     from django.utils.functional import _StrPromise
@@ -35,7 +34,7 @@ def __new__(cls, name, bases, attrs):
         return new_cls
 
 
-class IPlugin2(local, PluginConfigMixin, PluginStatusMixin):
+class IPlugin2(local, PluginConfigMixin):
     """
     Plugin interface. Should not be inherited from directly.
 
@@ -68,7 +67,6 @@ class IPlugin2(local, PluginConfigMixin, PluginStatusMixin):
     conf_title: str | _StrPromise | None = None
 
     project_conf_form: Any = None
-    project_conf_template = "sentry/plugins/project_configuration.html"
 
     # Global enabled state
     enabled = True
@@ -175,44 +173,15 @@ def get_conf_key(self):
             self.conf_key = self.get_conf_title().lower().replace(" ", "_")
         return self.conf_key
 
-    def get_conf_form(self, project=None):
-        """
-        Returns the Form required to configure the plugin.
-
-        >>> plugin.get_conf_form(project)
-        """
-        if project is not None:
-            return self.project_conf_form
-        return self.site_conf_form
-
-    def get_conf_template(self, project=None):
-        """
-        Returns the template required to render the configuration page.
-
-        >>> plugin.get_conf_template(project)
-        """
-        if project is not None:
-            return self.project_conf_template
-        return self.site_conf_template
-
     def get_conf_title(self):
         """
         Returns a string representing the title to be shown on the configuration page.
         """
         return self.conf_title or self.get_title()
 
-    def get_form_initial(self, project=None):
-        return {}
-
     def has_project_conf(self):
         return self.project_conf_form is not None
 
-    def has_plugin_conf(self):
-        """
-        Checks if the plugin should be returned in the ProjectPluginsEndpoint
-        """
-        return self.has_project_conf()
-
     def can_configure_for_project(self, project):
         """
         Checks if the plugin can be configured for a specific project.
@@ -273,19 +242,6 @@ def get_description(self):
         """
         return self.description
 
-    def get_resource_links(self):
-        """
-        Returns a list of tuples pointing to various resources for this plugin.
-
-        >>> def get_resource_links(self):
-        >>>     return [
-        >>>         ('Documentation', 'https://docs.sentry.io'),
-        >>>         ('Report Issue', 'https://github.com/getsentry/sentry/issues'),
-        >>>         ('View Source', 'https://github.com/getsentry/sentry'),
-        >>>     ]
-        """
-        return self.resource_links
-
     def get_rules(self, **kwargs):
         """
         Return a list of Rule classes to add to the registry.
@@ -373,23 +329,6 @@ def get_stacktrace_processors(self, data, stacktrace_infos,
                     return [CocoaProcessor(data, stacktrace_infos)]
         """
 
-    def get_feature_hooks(self, **kwargs):
-        """
-        Return a list of callables to check for feature status.
-
-        >>> from sentry.features import FeatureHandler
-        >>>
-        >>> class NoRegistration(FeatureHandler):
-        >>>     features = set(['auth:register'])
-        >>>
-        >>>     def has(self, feature, actor):
-        >>>         return False
-
-        >>> def get_feature_hooks(self, **kwargs):
-        >>>     return [NoRegistration()]
-        """
-        return []
-
     def get_release_hook(self) -> type[ReleaseHook] | None:
         """
         Return an implementation of ``ReleaseHook``.

src/sentry/plugins/bases/issue.py

@@ -91,12 +91,6 @@ def get_new_issue_title(self, **kwargs):
         """
         return "Create %s Issue" % self.get_title()
 
-    def get_unlink_issue_title(self, **kwargs):
-        """
-        Return a string for the "Unlink plugin issue" action label.
-        """
-        return "Unlink %s Issue" % self.get_title()
-
     def get_new_issue_form(self, request: Request, group, event, **kwargs):
         """
         Return a Form for the "Create new issue" page.
@@ -119,12 +113,6 @@ def get_issue_url(self, group, issue_id: str) -> str:
         """
         raise NotImplementedError
 
-    def get_issue_title_by_id(self, request: Request, group, issue_id):
-        """
-        Given an issue_id return the issue's title.
-        """
-        raise NotImplementedError
-
     def get_issue_label(self, group, issue_id) -> str:
         """
         Given an issue_id (string) return a string representing the issue.
@@ -157,10 +145,6 @@ def has_auth_configured(self, **kwargs):
 
         return self.auth_provider in get_auth_providers()
 
-    def handle_unlink_issue(self, request: Request, group, **kwargs):
-        GroupMeta.objects.unset_value(group, "%s:tid" % self.get_conf_key())
-        return self.redirect(group.get_absolute_url())
-
     def view(self, request: Request, group, **kwargs):
         has_auth_configured = self.has_auth_configured()
         if not (has_auth_configured and self.is_configured(project=group.project)):
@@ -269,8 +253,5 @@ def tags(self, request: Request, group, tag_list, **kwargs):
 
         return tag_list
 
-    def get_issue_doc_html(self, **kwargs):
-        return ""
-
 
 IssuePlugin = IssueTrackingPlugin