Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eap): Remove static sample count thresholds #6892

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Feb 17, 2025

The reliability flag is supposed to return the mathematical accuracy
based on the sample rate without other additional heuristics applied.
Currently, the calculation also compares the sample count with a static
threshold (count > 100) and returns low reliability if the count is
below.

Going forward, any checks for a static sample count threshold will be
performed outside of the EAP.

Confidence calculation for aggregations other than AVG will be fixed in
follow-up PRs.

Requires getsentry/sentry#85323
Ref https://github.com/getsentry/eap-planning/issues/192

@jan-auer jan-auer requested review from a team as code owners February 17, 2025 09:57
Copy link

codecov bot commented Feb 17, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2862 1 2861 11
View the top 1 failed test(s) by shortest run time
tests.web.rpc.v1.test_endpoint_trace_item_table.test_endpoint_trace_item_table_extrapolation.TestTraceItemTableWithExtrapolation::test_count_reliability_backward_compat
Stack Traces | 0.322s run time
Traceback (most recent call last):
  File ".../v1/test_endpoint_trace_item_table/test_endpoint_trace_item_table_extrapolation.py", line 405, in test_count_reliability_backward_compat
    assert (
AssertionError: assert 2 == 1
 +  where 1 = <google.protobuf.internal.enum_type_wrapper.EnumTypeWrapper object at 0x7f7be3e55150>.RELIABILITY_LOW

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@jan-auer jan-auer merged commit e265797 into master Feb 19, 2025
32 checks passed
@jan-auer jan-auer deleted the fix/eap-rem-static-thresholds branch February 19, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants