Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eap): Remove static sample count thresholds #6892

Merged
merged 2 commits into from
Feb 19, 2025
Merged

fix(eap): Remove static sample count thresholds #6892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a16f046
fix(eap): Remove static sample count thresholds
jan-auer Feb 17, 2025
f174afc
fix: Update tests
jan-auer Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 2 additions & 27 deletions snuba/web/rpc/v1/resolvers/common/aggregation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,12 +138,7 @@ def reliability(self) -> Reliability.ValueType:
if self.value != 0
else float("inf")
)
is_reliable = calculate_reliability(
relative_confidence,
self.sample_count,
CONFIDENCE_INTERVAL_THRESHOLD,
)
if is_reliable:
if relative_confidence <= CONFIDENCE_INTERVAL_THRESHOLD:
return Reliability.RELIABILITY_HIGH
return Reliability.RELIABILITY_LOW

Expand Down Expand Up @@ -174,12 +169,7 @@ def reliability(self) -> Reliability.ValueType:
self.value / ci_lower if ci_lower != 0 else float("inf"),
ci_upper / self.value if self.value != 0 else float("inf"),
)
is_reliable = calculate_reliability(
relative_confidence,
self.sample_count,
CONFIDENCE_INTERVAL_THRESHOLD,
)
if is_reliable:
if relative_confidence <= CONFIDENCE_INTERVAL_THRESHOLD:
return Reliability.RELIABILITY_HIGH
return Reliability.RELIABILITY_LOW

Expand Down Expand Up @@ -603,21 +593,6 @@ def _calculate_approximate_ci_percentile_levels(
return (lower_index / n, upper_index / n)


def calculate_reliability(
relative_confidence: float,
sample_count: int,
confidence_interval_threshold: float,
sample_count_threshold: int = 100,
) -> bool:
"""
A reliability check to determine if the sample count is large enough to be reliable and the confidence interval is small enough.
"""
if sample_count < sample_count_threshold:
return False

return relative_confidence <= confidence_interval_threshold


def aggregation_to_expression(
aggregation: AttributeAggregation, field: Expression | None = None
) -> Expression:
Expand Down
28 changes: 8 additions & 20 deletions ...web/rpc/v1/test_endpoint_trace_item_table/test_endpoint_trace_item_table_extrapolation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,9 +402,7 @@ def test_count_reliability_backward_compat(self) -> None:
0
]
assert measurement_count == 5
assert (
measurement_reliability == Reliability.RELIABILITY_LOW
) # low reliability due to low sample count
assert measurement_reliability == Reliability.RELIABILITY_HIGH

def test_count_reliability(self) -> None:
spans_storage = get_storage(StorageKey("eap_spans"))
Expand Down Expand Up @@ -461,9 +459,7 @@ def test_count_reliability(self) -> None:
0
]
assert measurement_count == 5
assert (
measurement_reliability == Reliability.RELIABILITY_LOW
) # low reliability due to low sample count
assert measurement_reliability == Reliability.RELIABILITY_HIGH

def test_count_reliability_with_group_by_backward_compat(self) -> None:
spans_storage = get_storage(StorageKey("eap_spans"))
Expand Down Expand Up @@ -578,17 +574,13 @@ def test_count_reliability_with_group_by_backward_compat(self) -> None:
measurement_counts = [v.val_double for v in response.column_values[3].results]
measurement_reliabilities = [v for v in response.column_values[3].reliabilities]
assert measurement_counts == [5]
assert measurement_reliabilities == [
Reliability.RELIABILITY_LOW,
] # low reliability due to low sample count
assert measurement_reliabilities == [Reliability.RELIABILITY_HIGH]

measurement_p90s = [v.val_double for v in response.column_values[4].results]
measurement_reliabilities = [v for v in response.column_values[4].reliabilities]
assert len(measurement_p90s) == 1
assert measurement_p90s[0] == 4
assert measurement_reliabilities == [
Reliability.RELIABILITY_LOW,
] # low reliability due to low sample count
assert measurement_reliabilities == [Reliability.RELIABILITY_HIGH]

def test_count_reliability_with_group_by(self) -> None:
spans_storage = get_storage(StorageKey("eap_spans"))
Expand Down Expand Up @@ -703,17 +695,13 @@ def test_count_reliability_with_group_by(self) -> None:
measurement_counts = [v.val_double for v in response.column_values[3].results]
measurement_reliabilities = [v for v in response.column_values[3].reliabilities]
assert measurement_counts == [5]
assert measurement_reliabilities == [
Reliability.RELIABILITY_LOW,
] # low reliability due to low sample count
assert measurement_reliabilities == [Reliability.RELIABILITY_HIGH]

measurement_p90s = [v.val_double for v in response.column_values[4].results]
measurement_reliabilities = [v for v in response.column_values[4].reliabilities]
assert len(measurement_p90s) == 1
assert measurement_p90s[0] == 4
assert measurement_reliabilities == [
Reliability.RELIABILITY_LOW,
] # low reliability due to low sample count
assert measurement_reliabilities == [Reliability.RELIABILITY_HIGH]

def test_formula(self) -> None:
"""
Expand Down Expand Up @@ -873,7 +861,7 @@ def test_aggregation_with_nulls(self) -> None:
attribute_name="sum(custom_measurement)",
results=[AttributeValue(val_double=5), AttributeValue(is_null=True)],
reliabilities=[
Reliability.RELIABILITY_LOW,
Reliability.RELIABILITY_HIGH,
Reliability.RELIABILITY_UNSPECIFIED,
],
),
Expand All @@ -882,7 +870,7 @@ def test_aggregation_with_nulls(self) -> None:
results=[AttributeValue(is_null=True), AttributeValue(val_double=5)],
reliabilities=[
Reliability.RELIABILITY_UNSPECIFIED,
Reliability.RELIABILITY_LOW,
Reliability.RELIABILITY_HIGH,
],
),
]
Loading