Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configurable storage class #136

Merged
merged 4 commits into from
Aug 12, 2024
Merged

configurable storage class #136

merged 4 commits into from
Aug 12, 2024

Conversation

vxav
Copy link
Contributor

@vxav vxav commented Aug 12, 2024

This pr adds the capability to specify a storage policy or none for the default vSphere csi storage class. Setting no storage policy is required in some cases.

This is a proposal to only create (or not) one single default storage class with the cluster chart. As a result I made the reclaimPolicy configurable along with the vSphere storage policy.

The idea is to offer the customer the ability to easily create a default SC, other SCs can be created manually.

Consumed by giantswarm/cluster-vsphere#264

Towards giantswarm/roadmap#3626

@vxav vxav marked this pull request as ready for review August 12, 2024 09:25
@vxav vxav requested a review from a team as a code owner August 12, 2024 09:25
@glitchcrab
Copy link
Member

@vxav vxav merged commit f11bc1f into main Aug 12, 2024
5 checks passed
@vxav vxav deleted the configurable-sc branch August 12, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants