Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configurable storage class #264

Merged
merged 9 commits into from
Aug 12, 2024
Merged

configurable storage class #264

merged 9 commits into from
Aug 12, 2024

Conversation

vxav
Copy link
Contributor

@vxav vxav commented Aug 12, 2024

This pr adds the capability to specify a storage policy or none for the default vSphere csi storage class. Setting no storage policy is required in some cases.

It is also possible to not create a default policy and set the reclaimPolicy. Here we only create one SC as we never really used the reclaim policy.

The idea is to offer the customer the ability to easily create a default SC, other SCs can be created manually.

Consumes giantswarm/cloud-provider-vsphere-app#136

Towards giantswarm/roadmap#3626

Trigger e2e tests

/run cluster-test-suites

@tinkerers-ci

This comment has been minimized.

@vxav
Copy link
Contributor Author

vxav commented Aug 12, 2024

/run cluster-test-suites

@tinkerers-ci
Copy link

tinkerers-ci bot commented Aug 12, 2024

cluster-test-suites

Run name pr-cluster-vsphere-264-cluster-test-suitesmgllj
Commit SHA 314cd69
Result Completed ✅

📋 View full results in Tekton Dashboard

Rerun trigger:
/run cluster-test-suites


Tip

To only re-run the failed test suites you can provide a TARGET_SUITES parameter with your trigger that points to the directory path of the test suites to run, e.g. /run cluster-test-suites TARGET_SUITES=./providers/capa/standard to re-run the CAPA standard test suite. This supports multiple test suites with each path separated by a comma.

@vxav vxav marked this pull request as ready for review August 12, 2024 10:35
@vxav vxav requested a review from a team as a code owner August 12, 2024 10:35
Copy link
Contributor

There were differences in the rendered Helm template, please check! ⚠️

Output
=== Differences when rendered with values file helm/cluster-vsphere/ci/test-wc-values.yaml ===

/spec/chart/spec/version  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/release-name-cloud-provider-vsphere)
  ± value change
    - 1.10.0
    + 1.11.0

/spec/values  (helm.toolkit.fluxcd.io/v2beta1/HelmRelease/org-giantswarm/release-name-cloud-provider-vsphere)
  + one map entry added:
    vsphere-csi-driver:
      storageClass:
        enabled: true
        reclaimPolicy: Delete

Copy link
Member

@glitchcrab glitchcrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems sensible

@vxav vxav added the skip/ci Instructs pr-gatekeeper to ignore any required PR checks label Aug 12, 2024
@vxav vxav merged commit 7019474 into main Aug 12, 2024
13 checks passed
@vxav vxav deleted the configurable-storage-class branch August 12, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/ci Instructs pr-gatekeeper to ignore any required PR checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants