-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Before and PartOf within unit section of custom systemd configuration #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…temd configuration
Closed
Hey @glitchcrab, a test pull request has been created for you in the cluster-aws repo! Go to pull request giantswarm/cluster-aws#879 in order to test your cluster chart changes on AWS. |
Gacko
approved these changes
Oct 1, 2024
…ustom systemd configuration
glitchcrab
force-pushed
the
more-systemd-options
branch
from
October 1, 2024 20:35
8d1ca21
to
69e1dab
Compare
Gacko
reviewed
Oct 1, 2024
ok I'm done adding stuff, this is ready to be reviewed please 🙏 |
I decided that I might as well add support for |
There were no differences in the rendered Helm template. Output
|
AverageMarcus
approved these changes
Oct 2, 2024
vxav
approved these changes
Oct 2, 2024
anvddriesch
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What is the effect of this change to users?
None, backwards compatible addition which is configured by provider charts.
How does it look like?
N/A
Any background context you can provide?
See #351
What is needed from the reviewers?
Do the docs need to be updated?
Should this change be mentioned in the release notes?