Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Before and PartOf within unit section of custom systemd configuration #355

Merged
merged 5 commits into from
Oct 2, 2024

Conversation

glitchcrab
Copy link
Member

@glitchcrab glitchcrab commented Oct 1, 2024

What does this PR do?

What is the effect of this change to users?

None, backwards compatible addition which is configured by provider charts.

How does it look like?

N/A

Any background context you can provide?

See #351

What is needed from the reviewers?

Do the docs need to be updated?

Should this change be mentioned in the release notes?

  • CHANGELOG.md has been updated (if it exists)

@glitchcrab glitchcrab requested a review from a team as a code owner October 1, 2024 19:41
@glitchcrab glitchcrab self-assigned this Oct 1, 2024
@glitchcrab glitchcrab requested a review from a team October 1, 2024 19:41
@glitchcrab glitchcrab mentioned this pull request Oct 1, 2024
@taylorbot
Copy link
Contributor

Hey @glitchcrab, a test pull request has been created for you in the cluster-aws repo! Go to pull request giantswarm/cluster-aws#879 in order to test your cluster chart changes on AWS.

@glitchcrab glitchcrab requested a review from a team October 1, 2024 21:04
@glitchcrab
Copy link
Member Author

ok I'm done adding stuff, this is ready to be reviewed please 🙏

@glitchcrab
Copy link
Member Author

I decided that I might as well add support for EnvironmentFile while I'm at it too.

Copy link

github-actions bot commented Oct 1, 2024

There were no differences in the rendered Helm template.

Output
=== Differences when rendered with values file helm/cluster/ci/test-required-values.yaml ===

No difference


=== Differences when rendered with values file helm/cluster/ci/test-zot-mc-and-local-values.yaml ===

No difference


=== Differences when rendered with values file helm/cluster/ci/test-zot-mc-values.yaml ===

No difference


=== Differences when rendered with values file helm/cluster/ci/test-zot-only-local-values.yaml ===

No difference


=== No differences at all ===

@glitchcrab glitchcrab requested a review from a team October 1, 2024 21:24
@glitchcrab glitchcrab merged commit 01fc1fb into main Oct 2, 2024
16 checks passed
@glitchcrab glitchcrab deleted the more-systemd-options branch October 2, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants