Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add inference framework #14

Merged
merged 5 commits into from
Dec 16, 2024
Merged

refactor: add inference framework #14

merged 5 commits into from
Dec 16, 2024

Conversation

szhao045
Copy link
Collaborator

Small refactor to clearly distinguish an inference framework (i.e., an application) from an underlying model (i.e., borzoi) for promoter activity.

@szhao045 szhao045 requested a review from Zulko December 16, 2024 17:33
Copy link
Collaborator

@Zulko Zulko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments. Do you have time to check why the tests are failing for Python3.12 ?

ginkgo_ai_client/queries.py Outdated Show resolved Hide resolved
test/test_models.py Outdated Show resolved Hide resolved
@Zulko Zulko merged commit 6ab6482 into main Dec 16, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants