Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for ABAP CDS #5954

Closed
wants to merge 1 commit into from
Closed

Conversation

BeckerWdf
Copy link

Support for ABAP CDS was introduces with PR #4614.

".acds" is just another alternative file extension to ".asddls".
This is officially documented by SAP in
https://github.com/SAP/abap-file-formats

See:

Description

Checklist:

  • I am associating a language with a new file extension.

  • I am adding a new language.

    • The extension of the new language is used in hundreds of repositories on GitHub.com.
    • I have included a real-world usage sample for all extensions added in this PR:
      • Sample source(s):
        • [URL to each sample source, if applicable]
      • Sample license(s):
    • I have included a syntax highlighting grammar: [URL to grammar repo]
    • I have updated the heuristics to distinguish my language from others using the same extension.
  • I am fixing a misclassified language

    • I have included a new sample for the misclassified language:
      • Sample source(s):
        • [URL to each sample source, if applicable]
      • Sample license(s):
    • I have included a change to the heuristics to distinguish my language from others using the same extension.
  • I am changing the source of a syntax highlighting grammar

    • Old: [URL to grammar repo]
    • New: [URL to grammar repo]
  • I am updating a grammar submodule

  • I am adding new or changing current functionality

    • I have added or updated the tests for the new or changed functionality.
  • I am changing the color associated with a language

    • I have obtained agreement from the wider language community on this color change.
      • [URL to public discussion]
      • [Optional: URL to official branding guidelines for the language]

@BeckerWdf BeckerWdf requested a review from a team as a code owner June 29, 2022 12:09
@lildude
Copy link
Member

lildude commented Jun 29, 2022

You appear to have missed a few details in the CONTRIBUTING.md file regarding adding a sample, and more importantly about usage requirements.

There are only three files indexed on GitHub right now, two of which you referenced 😁. This is a long long long way from our standard usage requirements and even our temporarily relaxed requirements detailed in #5756.

I'm closing this PR as the usage is a long way from meeting inclusion requirements and I doubt it'll go from 3 to 2000 or 200 unique repos any time soon. Please feel free to submit a new PR when usage levels are higher. In the meantime you can use an override in your repos to set the language.

@lildude lildude closed this Jun 29, 2022
@BeckerWdf
Copy link
Author

In the meantime you can use an override in your repos to set the language.

Can you pls. explain what exactly using an "override" means?

@lildude
Copy link
Member

lildude commented Jun 29, 2022

Sure. We've got a doc for that: https://github.com/github/linguist/blob/master/docs/overrides.md

@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants