Skip to content

Refactor digForDatabaseItem and digForDatabaseWithSameLanguage methods for skeleton wizard #2297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 12, 2023
Merged

Refactor digForDatabaseItem and digForDatabaseWithSameLanguage methods for skeleton wizard #2297

merged 5 commits into from
Apr 12, 2023

Conversation

@elenatanasoiu
Copy link
Contributor

@elenatanasoiu elenatanasoiu commented Apr 11, 2023

Came out of #2250 (comment)

This required moving the digForDatabaseItem & digForDatabaseWithSameLanguage methods into the SkeletonQueryWizard class.

In order to do this we had to:

  • extract some factories from the local-databases.test.ts file so we can set up a mock database manager
  • move the methods
  • adapt our tests

We're also:

  • renaming the methods to make them more consistent with other search methods for database items.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@elenatanasoiu elenatanasoiu requested review from a team as code owners April 11, 2023 17:16
This was referenced Apr 11, 2023
Merged
Merged
Merged
@elenatanasoiu elenatanasoiu force-pushed the elena/yer-a-lizard-query branch from 6f6d0e2 to de4afae Compare April 12, 2023 09:17
@elenatanasoiu
Move db mocking into factory file
0ff2e83 
So we can re-use it.
@elenatanasoiu
Move database Item search methods into skeleton wizard
6b26323 
And the tests for it. We can now re-use the factory from the previous commit.
@elenatanasoiu
Rename search methods
72b2080 
To be consistent with other database item search methods, we're renaming
ours:

`digForDatabaseItem` -> `findDatabaseItemByNwo`
and
`digForDatabaseItemSameLanguage` -> `findDatabaseItemByLanguage`
@elenatanasoiu
Move back mockCli into beforeEach
a6ffb6b 
This was an attempt to make the tests run in a shorter timeframe, but
we've gone with increasing the timeout to 40s.
@elenatanasoiu elenatanasoiu force-pushed the elena/improvements-to-wizard branch from a5b2d1c to a6ffb6b Compare April 12, 2023 09:38
koesie10
koesie10 approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@koesie10 koesie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

Base automatically changed from elena/yer-a-lizard-query to main April 12, 2023 16:39
@elenatanasoiu elenatanasoiu merged commit eabcd00 into main Apr 12, 2023
@elenatanasoiu elenatanasoiu deleted the elena/improvements-to-wizard branch April 12, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koesie10 koesie10 koesie10 approved these changes

Assignees

No one assigned

Labels

secexp

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elenatanasoiu @koesie10