Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-op query service implementation #31

Merged
merged 1 commit into from
May 3, 2024

Conversation

chris-allan
Copy link
Member

No-op query service implementation for use by the various microservices where required.

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See glencoesoftware/omero-zarr-pixel-buffer#5

At the moment, the only difference between the ZarrPixelBuffer stack in the server or in the micro-service is the injection and usage of the IQuery. This PR should allow us to load a single source of truth for the classes and the Spring configuration and inject a no-op IQUery implementation within the micro-service.

As per glencoesoftware/omero-zarr-pixel-buffer#5, proposing to get this merged and work on the image-region work to consume this new class

@sbesson sbesson merged commit 05b85a1 into glencoesoftware:master May 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants