Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add residue metadata to SVG tags #54

Closed
wants to merge 10 commits into from
Closed

Conversation

GABRAH
Copy link
Collaborator

@GABRAH GABRAH commented Oct 15, 2023

This pull request addresses the following issue: #40

Unfortunately I was not able to integrate these changes with the frontend as I was unable to install privateer_wasm, need individual help with that one.

Anyway, the residue metadata in SVG tags should appear like this:
Normal glycans(points both to amino acid and individual sugars):
image
Ligands(notice how the metadata is pointing to the first sugar rather than amino acid):
image

I think the residue metadata in the following format chainID="f" resname="NAG" seqnum="1" should be enough to build a query parameter in Moorhen.

Please let me know if you'd like anything adjusted or if this does not work at all :D

@GABRAH GABRAH added the webapp Issues relating to the Privateer webapp label Oct 15, 2023
@GABRAH GABRAH requested review from glycojones and Dialpuri October 15, 2023 16:28
To avoid merge conflicts
To resolve merge conflicts
@Dialpuri
Copy link
Collaborator

Looks good, I will test it out properly tomorrow 😀

@GABRAH
Copy link
Collaborator Author

GABRAH commented Oct 15, 2023

Apologies for causing merge conflicts. I messed up by creating this new branch from main, rather than webserver.
I thought that GitHub would be smart enough to not attempt overwrite webserver specific files with versions from main, but that appears to not be the case.

When merging these changes, attention needs to be paid to:

.gitignore
CMakeLists.txt

After the merge is complete, this branch can be deleted.

@Dialpuri Dialpuri closed this Oct 20, 2023
@GABRAH GABRAH deleted the feat_residue_metadata_svg branch October 29, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
webapp Issues relating to the Privateer webapp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants