Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Citation Modal #87

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Add Citation Modal #87

merged 3 commits into from
Jan 25, 2024

Conversation

Dialpuri
Copy link
Collaborator

Description

This PR adds a citation modal to the bookmark icon in the NavBar as opposed to the previous behaviour of forwarding the site to the original Privateer paper.

Changes

  • Added CitationModal component
  • Updated NavBar

Integrated a citation modal to the NavBar and added 'react-modal' to the dependencies. This modal provides users with appropriate citation information. Associated state management for the modal's open/close status was added.

Signed-off-by: Jordan Dialpuri <[email protected]>
The NavBar and CitationModal components have been revised for better code readability and performance.

Signed-off-by: Jordan Dialpuri <[email protected]>
@Dialpuri
Copy link
Collaborator Author

Dialpuri commented Jan 25, 2024

@lcs551, can you test this new feature, shouldn't take long. Thank you!

When you pull this branch, you will have to run
npm ci
before you run the dev server.

@Dialpuri
Copy link
Collaborator Author

Dialpuri commented Jan 25, 2024

This PR would close #86

The Footer component's text has been edited to display 'York Structural Biology Laboratory' instead of individual names, providing a more general attribution. This update simplifies the footer's content and enhances its uniformity with the overall web page design.

Signed-off-by: Jordan Dialpuri <[email protected]>
@lcs551 lcs551 merged commit 375edb8 into webapp Jan 25, 2024
2 checks passed
@Dialpuri Dialpuri deleted the add_citation branch January 29, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants