Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSW-1838 refactor: use avl.Tree in pool #430

Merged
merged 1 commit into from
Dec 19, 2024
Merged

GSW-1838 refactor: use avl.Tree in pool #430

merged 1 commit into from
Dec 19, 2024

Conversation

r3v4s
Copy link
Member

@r3v4s r3v4s commented Dec 10, 2024 •
edited
Loading

refactor

  1. use avl.Tree instead of map
  • currently map has issue with processing pointer value as key

image

@r3v4s r3v4s requested review from notJoon and onlyhyde December 10, 2024 08:28
@r3v4s r3v4s self-assigned this Dec 10, 2024
@r3v4s r3v4s added refactoring pool Pool contract related tasks labels Dec 10, 2024
notJoon
notJoon previously approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@notJoon notJoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Base automatically changed from refactor/pool_grc20reg to main December 11, 2024 04:31
@notJoon notJoon dismissed their stale review December 11, 2024 04:31

The base branch was changed.

@dongwon8247 dongwon8247 changed the title GSW-1838 refactor: use avl.Tree GSW-1838 refactor: use avl.Tree in pool Dec 12, 2024
@r3v4s r3v4s mentioned this pull request Dec 13, 2024
Open
onlyhyde
onlyhyde requested changes Dec 15, 2024
View reviewed changes
Copy link
Member

@onlyhyde onlyhyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The base code of the current pr is too old; the application of avl.Tree should be applied from the modernized pool code. Needs to be updated

pool/tick.gno Outdated Show resolved Hide resolved
pool/tick.gno Outdated Show resolved Hide resolved
pool/tick.gno Outdated Show resolved Hide resolved
pool/tick_bitmap.gno Outdated Show resolved Hide resolved
pool/tick_bitmap.gno Outdated Show resolved Hide resolved
pool/tick_bitmap.gno Outdated Show resolved Hide resolved
@r3v4s r3v4s force-pushed the refactor/pool_avl-instead-of-map branch from adec74f to bf8e09d Compare December 16, 2024 02:10
@r3v4s r3v4s marked this pull request as draft December 16, 2024 02:20
@r3v4s r3v4s marked this pull request as ready for review December 16, 2024 03:47
@r3v4s r3v4s requested review from onlyhyde and notJoon December 16, 2024 03:47
@r3v4s r3v4s force-pushed the refactor/pool_avl-instead-of-map branch from a926b6c to 71190c0 Compare December 16, 2024 06:35
notJoon
notJoon previously approved these changes Dec 17, 2024
View reviewed changes
@r3v4s r3v4s force-pushed the refactor/pool_avl-instead-of-map branch from 71190c0 to 2e3de24 Compare December 18, 2024 07:48
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@r3v4s r3v4s requested a review from notJoon December 18, 2024 09:16
@notJoon notJoon merged commit 1e9c270 into main Dec 19, 2024
1 of 2 checks passed
@notJoon notJoon deleted the refactor/pool_avl-instead-of-map branch December 19, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onlyhyde onlyhyde onlyhyde approved these changes

@notJoon notJoon notJoon approved these changes

Assignees

@r3v4s r3v4s

Labels
pool Pool contract related tasks refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r3v4s @notJoon @onlyhyde