[WIP] Parse query comments and pass metadata for max time query #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashmaheshwari
force-pushed
the
yash/parse_query_comments_and_pass_metadata_for_max_time_query
branch
from
2cd8462
to
dd8919f
Compare
yashmaheshwari
changed the title
yashmaheshwari
force-pushed
the
yash/parse_query_comments_and_pass_metadata_for_max_time_query
branch
from
dd8919f
to
ad96fd7
Compare
| lastDb string | ||
| sample bool | ||
| maxQueryTime float64 | ||
| MaxQueryCommentMetadata map[string]string |
There was a problem hiding this comment.
Let's call this just Metadata. The max query time stuff is something we do internally.
| BoolMetrics map[string]bool // yes/no metrics | ||
| RateType string // Percona Server rate limit type | ||
| RateLimit uint // Percona Server rate limit value | ||
| CommentMetadata map[string]string |
There was a problem hiding this comment.
Same as above: just Metadata.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing: Tests for parsing query comments