-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Parse query comments and pass metadata for max time query #1
Open
yashmaheshwari
wants to merge
2
commits into
master
Choose a base branch
from
yash/parse_query_comments_and_pass_metadata_for_max_time_query
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,18 +12,19 @@ package slowlog | |
// event is expected to define the query and Query_time metric. Other metrics | ||
// and metadata vary according to MySQL version, distro, and configuration. | ||
type Event struct { | ||
Offset uint64 // byte offset in file at which event starts | ||
Ts string // raw timestamp of event | ||
Admin bool // true if Query is admin command | ||
Query string // SQL query or admin command | ||
User string | ||
Host string | ||
Db string | ||
TimeMetrics map[string]float64 // *_time and *_wait metrics | ||
NumberMetrics map[string]uint64 // most metrics | ||
BoolMetrics map[string]bool // yes/no metrics | ||
RateType string // Percona Server rate limit type | ||
RateLimit uint // Percona Server rate limit value | ||
Offset uint64 // byte offset in file at which event starts | ||
Ts string // raw timestamp of event | ||
Admin bool // true if Query is admin command | ||
Query string // SQL query or admin command | ||
User string | ||
Host string | ||
Db string | ||
TimeMetrics map[string]float64 // *_time and *_wait metrics | ||
NumberMetrics map[string]uint64 // most metrics | ||
BoolMetrics map[string]bool // yes/no metrics | ||
RateType string // Percona Server rate limit type | ||
RateLimit uint // Percona Server rate limit value | ||
CommentMetadata map[string]string | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above: just |
||
} | ||
|
||
// NewEvent returns a new Event with initialized metric maps. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's call this just
Metadata
. The max query time stuff is something we do internally.