Skip to content
reviewdog

fix(jwk): upgrade lestrrat-go/jwx to v2 #5988

Sign in to view logs

fix(jwk): upgrade lestrrat-go/jwx to v2

fix(jwk): upgrade lestrrat-go/jwx to v2 #5988

Triggered via pull request June 6, 2024 14:50
@ecrupperecrupper
opened #1138
chore/upgrade-jwx
Status Failure
Total duration 2m 37s
Artifacts –

reviewdog.yml

on: pull_request
diff-review
2m 28s
diff-review
full-review
2m 21s
full-review
Fit to window
Zoom out
Zoom in

Annotations

20 errors
full-review: database/jwk/list.go#L36
Error return value of `keySet.AddKey` is not checked (errcheck)
full-review: database/jwk/list_test.go#L57
Error return value of `wantSet.AddKey` is not checked (errcheck)
full-review: database/jwk/list_test.go#L58
Error return value of `wantSet.AddKey` is not checked (errcheck)
full-review: database/integration_test.go#L2579
Error return value of `jwkSet.AddKey` is not checked (errcheck)
full-review: database/integration_test.go#L2580
Error return value of `jwkSet.AddKey` is not checked (errcheck)
full-review: mock/server/authentication.go#L81
string `error` has 4 occurrences, make it a constant (goconst)
full-review: database/executable/clean.go#L31
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
full-review: database/executable/table.go#L38
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
full-review: database/executable/create.go#L17
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
full-review: scm/github/authentication.go#L59
unused-parameter: parameter 'w' seems to be unused, consider removing or renaming it as _ (revive)
diff-review: database/jwk/list.go#L36
Error return value of `keySet.AddKey` is not checked (errcheck)
diff-review: database/jwk/list_test.go#L57
Error return value of `wantSet.AddKey` is not checked (errcheck)
diff-review: database/jwk/list_test.go#L58
Error return value of `wantSet.AddKey` is not checked (errcheck)
diff-review: database/integration_test.go#L2579
Error return value of `jwkSet.AddKey` is not checked (errcheck)
diff-review: database/integration_test.go#L2580
Error return value of `jwkSet.AddKey` is not checked (errcheck)
diff-review: mock/server/authentication.go#L81
string `error` has 4 occurrences, make it a constant (goconst)
diff-review: database/executable/clean.go#L31
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
diff-review: database/executable/create.go#L17
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
diff-review: database/executable/pop.go#L16
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
diff-review: scm/github/authentication.go#L59
unused-parameter: parameter 'w' seems to be unused, consider removing or renaming it as _ (revive)