-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(build)!: move build from types and nest the object #1111
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1111 +/- ##
==========================================
+ Coverage 65.97% 67.75% +1.77%
==========================================
Files 383 391 +8
Lines 12310 13035 +725
==========================================
+ Hits 8122 8832 +710
- Misses 3666 3696 +30
+ Partials 522 507 -15
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice. some minor things. tested locally with WIP branches in sdk-go + worker. will need some tweak in UI to be able to parse new response, but looks good otherwise.
ListBuildsForDashboardRepo does not include repo preloading because I didn't see the point. Would not mind changing that if someone preferred it.
tripped me up at first, but i think it makes sense the way it is
Follow up from #1106, #1095, and #997
Of note:
type Build struct
insidedatabase/build/build.go
) to adatabase/types
package. This was sad but necessary due to import cycles when attempting to leverage Gorm SQL migration in the tests.testutils/api_resources.go
file. This was to prevent the duplication of API object instantiation that existed across the database package for testing.