Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add scm user id to build obj #1133

Merged
merged 7 commits into from
Jun 4, 2024
Merged

enhance: add scm user id to build obj #1133

merged 7 commits into from
Jun 4, 2024

Conversation

plyr4
Copy link
Contributor

@plyr4 plyr4 commented Jun 3, 2024

attaching the user's scm id to builds.

required for build identification via OIDC, see: #1120

scm/github/webhook.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 73.13433% with 18 lines in your changes missing coverage. Please review.

Project coverage is 68.04%. Comparing base (c35d01e) to head (37d5dfc).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1133      +/-   ##
==========================================
- Coverage   68.08%   68.04%   -0.04%     
==========================================
  Files         410      411       +1     
  Lines       13715    13752      +37     
==========================================
+ Hits         9338     9358      +20     
- Misses       3842     3859      +17     
  Partials      535      535              
Files Coverage Δ
api/types/build.go 91.76% <100.00%> (+0.19%) ⬆️
database/build/table.go 100.00% <ø> (ø)
database/types/build.go 100.00% <100.00%> (ø)
mock/server/build.go 0.00% <ø> (ø)
scm/github/webhook.go 90.75% <85.71%> (-0.16%) ⬇️
api/build/restart.go 0.00% <0.00%> (ø)
scm/github/user.go 0.00% <0.00%> (ø)

scm/github/user.go Outdated Show resolved Hide resolved
scm/github/user.go Show resolved Hide resolved
@plyr4 plyr4 marked this pull request as ready for review June 3, 2024 21:39
@plyr4 plyr4 requested a review from a team as a code owner June 3, 2024 21:39
ecrupper
ecrupper previously approved these changes Jun 4, 2024
wass3rw3rk
wass3rw3rk previously approved these changes Jun 4, 2024
@plyr4 plyr4 merged commit 4f81558 into main Jun 4, 2024
14 of 16 checks passed
@plyr4 plyr4 deleted the enhance/build-sender-id branch June 4, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants