chore(release): upgrade types to v0.24.0-rc1 #1136
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1136 +/- ##
=======================================
Coverage 52.01% 52.01%
=======================================
Files 548 548
Lines 18779 18779
=======================================
Hits 9767 9767
Misses 8457 8457
Partials 555 555 |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| return nil | ||
| } | ||
|
|
||
| jk.Set(jwk.KeyIDKey, kid.String()) |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
Error return value of jk.Set is not checked (errcheck)
| @@ -33,7 +33,7 @@ func (e *engine) ListJWKs(_ context.Context) (jwk.Set, error) { | |||
| tmp := key | |||
|
|
|||
| // convert query result to API type | |||
| keySet.Add(tmp.ToAPI()) | |||
| keySet.AddKey(tmp.ToAPI()) | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
Error return value of keySet.AddKey is not checked (errcheck)
| @@ -54,8 +54,8 @@ func TestJWK_Engine_ListJWKs(t *testing.T) { | |||
| } | |||
|
|
|||
| wantSet := jwk.NewSet() | |||
| wantSet.Add(_jwkOne) | |||
| wantSet.Add(_jwkTwo) | |||
| wantSet.AddKey(_jwkOne) | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
Error return value of wantSet.AddKey is not checked (errcheck)
| wantSet.Add(_jwkOne) | ||
| wantSet.Add(_jwkTwo) | ||
| wantSet.AddKey(_jwkOne) | ||
| wantSet.AddKey(_jwkTwo) |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
Error return value of wantSet.AddKey is not checked (errcheck)
| } | ||
|
|
||
| jk.Set(jwk.KeyIDKey, kid.String()) |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
Error return value of jk.Set is not checked (errcheck)
| @@ -2576,8 +2576,8 @@ func newResources() *Resources { | |||
| jwkTwo := testutils.JWK() | |||
|
|
|||
| jwkSet := jwk.NewSet() | |||
| jwkSet.Add(jwkOne) | |||
| jwkSet.Add(jwkTwo) | |||
| jwkSet.AddKey(jwkOne) | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
Error return value of jwkSet.AddKey is not checked (errcheck)
| jwkSet.Add(jwkOne) | ||
| jwkSet.Add(jwkTwo) | ||
| jwkSet.AddKey(jwkOne) | ||
| jwkSet.AddKey(jwkTwo) |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
Error return value of jwkSet.AddKey is not checked (errcheck)
| if err != nil { | ||
| return err | ||
| return nil |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
error is not nil (line 30) but it returns nil (nilerr)
No description provided.