chore(release): upgrade types to v0.24.0-rc1 #1136
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| // Use IntelliSense to learn about possible attributes. | ||
| // Hover to view descriptions of existing attributes. | ||
| // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387 | ||
| "version": "0.2.0", | ||
| "configurations": [] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,7 +12,7 @@ | |
|
|
||
| "github.com/adhocore/gronx" | ||
| "github.com/google/go-cmp/cmp" | ||
| "github.com/lestrrat-go/jwx/v2/jwk" | ||
|
|
||
| api "github.com/go-vela/server/api/types" | ||
| "github.com/go-vela/server/api/types/settings" | ||
|
|
@@ -878,7 +878,7 @@ | |
| } | ||
|
|
||
| for i := 0; i < resources.JWKs.Len(); i++ { | ||
| jk, _ := resources.JWKs.Key(i) | ||
|
|
||
| jkPub, _ := jk.(jwk.RSAPublicKey) | ||
|
|
||
|
|
@@ -901,7 +901,7 @@ | |
| methods["ListJWKs"] = true | ||
|
|
||
| for i := 0; i < resources.JWKs.Len(); i++ { | ||
| jk, _ := resources.JWKs.Key(i) | ||
|
|
||
| jkPub, _ := jk.(jwk.RSAPublicKey) | ||
|
|
||
|
|
@@ -923,7 +923,7 @@ | |
| } | ||
|
|
||
| for i := 0; i < resources.JWKs.Len(); i++ { | ||
| jk, _ := resources.JWKs.Key(i) | ||
|
|
||
| jkPub, _ := jk.(jwk.RSAPublicKey) | ||
|
|
||
|
|
@@ -2576,8 +2576,8 @@ | |
| jwkTwo := testutils.JWK() | ||
|
|
||
| jwkSet := jwk.NewSet() | ||
| jwkSet.AddKey(jwkOne) | ||
|
Check failure on line 2579 in database/integration_test.go
|
||
| jwkSet.AddKey(jwkTwo) | ||
|
Check failure on line 2580 in database/integration_test.go
|
||
|
There was a problem hiding this comment. 🚫 [golangci] reported by reviewdog 🐶 |
||
|
|
||
| logServiceOne := new(library.Log) | ||
| logServiceOne.SetID(1) | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,7 @@ | |
| import ( | ||
| "context" | ||
|
|
||
| "github.com/lestrrat-go/jwx/v2/jwk" | ||
|
|
||
| "github.com/go-vela/server/constants" | ||
| "github.com/go-vela/server/database/types" | ||
|
|
@@ -33,7 +33,7 @@ | |
| tmp := key | ||
|
|
||
| // convert query result to API type | ||
| keySet.AddKey(tmp.ToAPI()) | ||
|
Check failure on line 36 in database/jwk/list.go
|
||
|
There was a problem hiding this comment. 🚫 [golangci] reported by reviewdog 🐶 |
||
| } | ||
|
|
||
| return keySet, nil | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,7 +9,7 @@ | |
| "testing" | ||
|
|
||
| "github.com/DATA-DOG/go-sqlmock" | ||
| "github.com/lestrrat-go/jwx/v2/jwk" | ||
|
|
||
| "github.com/go-vela/server/database/testutils" | ||
| ) | ||
|
|
@@ -54,8 +54,8 @@ | |
| } | ||
|
|
||
| wantSet := jwk.NewSet() | ||
| wantSet.AddKey(_jwkOne) | ||
|
Check failure on line 57 in database/jwk/list_test.go
|
||
|
There was a problem hiding this comment. 🚫 [golangci] reported by reviewdog 🐶 |
||
| wantSet.AddKey(_jwkTwo) | ||
|
Check failure on line 58 in database/jwk/list_test.go
|
||
|
There was a problem hiding this comment. 🚫 [golangci] reported by reviewdog 🐶 |
||
|
|
||
| // setup tests | ||
| tests := []struct { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,7 @@ | |
| "crypto/rsa" | ||
|
|
||
| "github.com/google/uuid" | ||
| "github.com/lestrrat-go/jwx/v2/jwk" | ||
|
|
||
| api "github.com/go-vela/server/api/types" | ||
| "github.com/go-vela/server/api/types/actions" | ||
|
|
@@ -288,10 +288,19 @@ | |
| return nil | ||
| } | ||
|
|
||
| pubKey, err := jwk.PublicRawKeyOf(&privateRSAKey.PublicKey) | ||
|
|
||
| if err != nil { | ||
| return nil | ||
| } | ||
|
|
||
| jk, ok := pubKey.(jwk.RSAPublicKey) | ||
|
|
||
| if !ok { | ||
| return nil | ||
| } | ||
|
|
||
| jk.Set(jwk.KeyIDKey, kid.String()) | ||
|
Check failure on line 303 in database/testutils/api_resources.go
|
||
|
There was a problem hiding this comment. 🚫 [golangci] reported by reviewdog 🐶 |
||
|
|
||
| return jk | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,7 +8,7 @@ import ( | |
| "errors" | ||
|
|
||
| "github.com/google/uuid" | ||
| "github.com/lestrrat-go/jwx/v2/jwk" | ||
| ) | ||
|
|
||
| var ( | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,7 +8,7 @@ | |
| "crypto/rsa" | ||
|
|
||
| "github.com/google/uuid" | ||
| "github.com/lestrrat-go/jwx/v2/jwk" | ||
|
|
||
| "github.com/go-vela/server/database" | ||
| ) | ||
|
|
@@ -27,20 +27,22 @@ | |
| return err | ||
| } | ||
|
|
||
| pubKey, err := jwk.PublicRawKeyOf(&privateRSAKey.PublicKey) | ||
|
|
||
| if err != nil { | ||
| return nil | ||
|
Check failure on line 33 in internal/token/generate_rsa.go
|
||
|
There was a problem hiding this comment. 🚫 [golangci] reported by reviewdog 🐶 |
||
| } | ||
|
|
||
| jk, ok := pubKey.(jwk.RSAPublicKey) | ||
|
|
||
| if !ok { | ||
| return nil | ||
| } | ||
|
|
||
| jk.Set(jwk.KeyIDKey, kid.String()) | ||
|
Check failure on line 42 in internal/token/generate_rsa.go
|
||
|
There was a problem hiding this comment. 🚫 [golangci] reported by reviewdog 🐶 |
||
|
|
||
| // create the JWK in the database | ||
| err = db.CreateJWK(context.TODO(), jk) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
Error return value of
jwkSet.AddKeyis not checked (errcheck)