Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api/build): cancel build removes build_executable from table #978

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

ecrupper
Copy link
Contributor

This will prevent stale build_executable items from piling up if users cancel pending builds.

@ecrupper ecrupper self-assigned this Sep 29, 2023
@ecrupper ecrupper requested a review from a team as a code owner September 29, 2023 17:32
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #978 (727be95) into main (3d1f418) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #978      +/-   ##
==========================================
- Coverage   71.09%   71.06%   -0.04%     
==========================================
  Files         312      312              
  Lines       12989    12996       +7     
==========================================
  Hits         9235     9235              
- Misses       3288     3295       +7     
  Partials      466      466              
Files Coverage Δ
api/build/cancel.go 0.00% <0.00%> (ø)

@ecrupper ecrupper merged commit f021c40 into main Sep 29, 2023
11 of 12 checks passed
@ecrupper ecrupper deleted the fix/build/cancel-pop-executable branch September 29, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants