Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(queue): add ping function for redis #991

Merged
merged 5 commits into from
Oct 31, 2023
Merged

feat(queue): add ping function for redis #991

merged 5 commits into from
Oct 31, 2023

Conversation

timhuynh94
Copy link
Contributor

@timhuynh94 timhuynh94 commented Oct 23, 2023

Closes #859

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #991 (3e78f3f) into main (3ee9ccf) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #991      +/-   ##
==========================================
+ Coverage   70.35%   70.37%   +0.01%     
==========================================
  Files         315      316       +1     
  Lines       13201    13209       +8     
==========================================
+ Hits         9288     9296       +8     
  Misses       3446     3446              
  Partials      467      467              
Files Coverage Δ
queue/redis/ping.go 100.00% <100.00%> (ø)

@timhuynh94 timhuynh94 marked this pull request as ready for review October 24, 2023 14:15
@timhuynh94 timhuynh94 requested a review from a team as a code owner October 24, 2023 14:15
plyr4
plyr4 previously approved these changes Oct 24, 2023
@ecrupper
Copy link
Contributor

I believe we ping the queue on start up when creating a new Redis connection. I imagine any logic based on the success/failure of pinging the queue could be branched off of whether or not the New(...) method was successful?

@timhuynh94
Copy link
Contributor Author

I believe we ping the queue on start up when creating a new Redis connection. I imagine any logic based on the success/failure of pinging the queue could be branched off of whether or not the New(...) method was successful?

The issue with New(...) method is that it only gets pinged once during setup and never pinged again unless New(...) method is called again. We could also entirely with the New(...) method logic by creating new queue client everytime the worker checks in with server.

@wass3r wass3r changed the title Feat(queue): add ping function for redis feat(queue): add ping function for redis Oct 26, 2023
@timhuynh94 timhuynh94 merged commit 6708cea into main Oct 31, 2023
12 checks passed
@timhuynh94 timhuynh94 deleted the feat_redis_ping branch October 31, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

worker status not reset after setting to error
4 participants