Skip to content

add overrides for some MultiplayerApi methods to have &self receiver rather than &mut self #1274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bcolloran
Copy link

Per this thread, adding overrides for some methods in MultiplayerApi that don't seem like they should need mutable access to self.

@bcolloran bcolloran force-pushed the multiplayer-api-mut-to-ref branch from a5f7274 to 467ddda Compare August 13, 2025 19:12
@Bromeon Bromeon added quality-of-life No new functionality, but improves ergonomics/internals c: engine Godot classes (nodes, resources, ...) labels Aug 13, 2025
@GodotRust
Copy link

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1274

@fstxz
Copy link

fstxz commented Aug 15, 2025

While you are at it, maybe do the same with CharFxTransform? Most of its getters take &mut self.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: engine Godot classes (nodes, resources, ...) quality-of-life No new functionality, but improves ergonomics/internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants