Godot FFI: postinit create, compat virtual methods, icon paths #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bromeon
added
feature
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-991 |
Use `I*` trait base class to lookup virtual hashes.
Bromeon
force-pushed
the
feature/compat-virtual-methods
branch
from
cec8620 to
9fa6c09
Compare
Bromeon
changed the title
…s ready Reduces the surface for merge conflicts. Either this commit can be individually reverted later, or locations with TODO(v0.3,virtual-compat) can be sought out.
Does not implement setting the icon path yet, but updates the C structs to match the GDExtension header. See https://www.github.com/godotengine/godot/pull/100193.
Bromeon
force-pushed
the
feature/compat-virtual-methods
branch
from
ee2e436 to
76386c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catches up with three upstream features for Godot 4.4 on the FFI level.
This PR only brings one of them to a user-facing feature though: virtual method compatibility.
The compatibility for virtual functions is not yet merged upstream. Since this PR grew quite a bit in the meantime, I want to avoid too much code divergence, so I'll merge the underlying hash compat system, while leaving some integration points disabled. This should be quickly patchable once Godot is ready. (TLDR: I'm optimistic this is going to be merged 🙂)