Privatise and Tidy #1665
Closed
Privatise and Tidy #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enetheru
force-pushed
the
tidy
branch
2 times, most recently
from
fe20f36 to
af8f04c
Compare
Simplify <platform>_generate cmake function signature, as TARGET_ALIAS and TARGET_NAME are still in scope and do not need to be passed. Add USE_FOLDERS, and FOLDER properties to group targets in VS and XCode Guard test target with GODOT_ENABLE_TESTING Generate all three variants in the form godot-cpp.test.<target> to remove the -DTEST_TARGET option clutter. Update the docs/cmake.rst with information about the testing target Update the Github CI
enetheru
force-pushed
the
tidy
branch
2 times, most recently
from
4d5b9ef to
13f6a93
Compare
There are tiny issues that don't effect the build that can be cleaned. And flags that can be made private to not effect consumers. Remove RPATH_USE_ORIGIN from static libs add INTERFACE_POSITION_INDEPENDENT_CODE ON reset GODOT_ARCH property to SYSTEM_ARCH for macos because universal add MACOSX_RPATH to test target remove redundant properties from test target remove redundant and PUBLIC cxx_std_17 compile feature Change compiler options to PRIVATE, tested on godot-cpp-test, and orchestrator Transform BITS if statement into simple math expression Transform binding parameters if statements into a genex
Calinou
added
archived
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the benefits of CMake which is not currently being realised is that target options can be selectively propagated to consumers. For expediency, I had previously made all the flags PUBLIC, which propagates all options to consumers. However, after some investigation, It appears that we can make the majority of them PRIVATE.
The compile_definitions must remain public as they are needed in consumer projects.
The compile_options and link_options can be made private and achieve a successful compile, but investigation is required for what should be propagated.
There are also flags and properties that can be tidied up to be more correct.
Remove RPATH_USE_ORIGIN from static libs
add INTERFACE_POSITION_INDEPENDENT_CODE ON
reset GODOT_ARCH property to SYSTEM_ARCH for macos because universal add MACOSX_RPATH to test target
remove redundant properties from test target
remove redundant and PUBLIC cxx_std_17 compile feature.
Move MSVC flag utf-8 to godot-cpp-test where it is required.