Docker: Use of alpine, pass in env vars and use pm2-runtime #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
app.json
file. This is due to them having precedent over passed in environment variables and defaults are already set inlib/node.js
emit
instance function for sending the hello/login message so errors are shown on failure and the message can be traced in the logsDocker refactor wins:
pm2-runtime
with no daemon mode allows the entrypoint to be a pm2 command which stops the container if the client quits, rather than forever running just withtail -f
even if the client exits.Please also rectify #2 so we can get the correct automated Docker hub builds.