Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade setup-python workflows #670

Merged
merged 5 commits into from
Dec 18, 2023
Merged

Upgrade setup-python workflows #670

merged 5 commits into from
Dec 18, 2023

Conversation

kaczmarczyck
Copy link
Collaborator

Maintenance PR for workflows

@kaczmarczyck kaczmarczyck requested review from ia0 and jmichelp December 18, 2023 10:00
@jmichelp
Copy link
Collaborator

Seems that actions/checkout@v2 is also issuing a warning.
Mind bumping it to v4 in this PR?

@kaczmarczyck
Copy link
Collaborator Author

Okay, I bumped all actions to the latest major versions, lets see.

jmichelp
jmichelp reviewed Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@jmichelp jmichelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Might be worth noting that cargo-bloat and binary-size-reports are the next 2 workflows which could break. But they require a bit more changes than bumping the version

@kaczmarczyck
Copy link
Collaborator Author

Yeah, I realized, but wanted to keep this low effort.

@kaczmarczyck kaczmarczyck merged commit 0185d1e into google:develop Dec 18, 2023
8 checks passed
@kaczmarczyck kaczmarczyck deleted the python-workflow branch December 18, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmichelp jmichelp jmichelp approved these changes

@ia0 ia0 Awaiting requested review from ia0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaczmarczyck @jmichelp