Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade setup-python workflows #670

Merged
merged 5 commits into from
Dec 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/cargo_audit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ jobs:
runs-on: ubuntu-latest
if: github.repository == 'google/OpenSK'
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
with:
submodules: "true"
- uses: actions/setup-python@v1
- uses: actions/setup-python@v5
with:
python-version: "3.10"
- name: Set up OpenSK
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/cargo_bloat.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ jobs:
runs-on: ubuntu-latest
steps:
# Setup
- uses: actions/setup-python@v1
- uses: actions/setup-python@v5
with:
python-version: "3.10"
- uses: actions-rs/cargo@v1
Expand All @@ -15,7 +15,7 @@ jobs:
args: cargo-bloat

# First run: PR
- uses: actions/checkout@v2
- uses: actions/checkout@v4
with:
submodules: true
- name: Set up OpenSK
Expand All @@ -24,7 +24,7 @@ jobs:
run: RUSTFLAGS="-C link-arg=-icf=all -C force-frame-pointers=no -C link-arg=-Tnrf52840_layout.ld" cargo bloat --release --target=thumbv7em-none-eabi --features=config_command,with_ctap1 --crates >> .github/workflows/bloat_output_new.txt

# Second run: PR
- uses: actions/checkout@v2
- uses: actions/checkout@v4
with:
submodules: true
ref: ${{ github.base_ref }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ jobs:
permissions:
contents: read
steps:
- uses: actions/checkout@v3
- uses: actions/setup-python@v1
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: "3.10"
- run: ./setup.sh
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cifuzz.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
fuzz-seconds: 600
dry-run: false
- name: Upload Crash
uses: actions/upload-artifact@v1
uses: actions/upload-artifact@v4
if: failure() && steps.build.outcome == 'success'
with:
name: artifacts
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/coveralls.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
with:
submodules: "true"
- name: Install Rust toolchain
run: rustup show
- uses: actions/setup-python@v1
- uses: actions/setup-python@v5
with:
python-version: "3.10"
- name: Set up OpenSK
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/mdlint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ jobs:
mdlint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: markdownlint-cli
uses: nosborn/github-action-markdown-cli@v1.1.1
uses: nosborn/github-action-markdown-cli@v3
with:
files: '**/*.md'
ignore_files: "third_party/*"
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/reproducible.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@ jobs:
fail-fast: false
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
with:
submodules: "true"
- name: Install Rust toolchain
run: rustup show
- uses: actions/setup-python@v1
- uses: actions/setup-python@v5
with:
python-version: "3.10"
- name: Set up OpenSK
Expand All @@ -30,7 +30,7 @@ jobs:
run: ./maintainers/reproduce_hashes.sh

- name: Upload reproduced binaries
uses: actions/upload-artifact@v1
uses: actions/upload-artifact@v4
with:
name: reproduced-${{ matrix.os }}
path: reproducible/reproduced.tar
Expand Down
6 changes: 3 additions & 3 deletions docs/install.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ might work for you.
### Compiling the firmware

If this is your first time installing OpenSK, please skip directly to
[Initial setup](#Initial-setup). Else, see
[Updating your setup](#Updating-your-setup) below.
[Initial setup](#initial-setup). Else, see
[Updating your setup](#updating-your-setup) below.

#### Updating your setup

Expand Down Expand Up @@ -140,7 +140,7 @@ From here on, please follow the instructions for your hardware:
### Advanced installation

We recommend that you flash your development board with JTAG and dongles with
DFU, as described in the [board documentation](#Flashing-a-firmware) linked
DFU, as described in the [board documentation](#flashing-a-firmware) linked
above. However, we support other programmers:

* OpenOCD: `./deploy.py --board=nrf52840_dongle_opensk --opensk
Expand Down
Loading