test: update unit test code for test_connection #578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anencore94
force-pushed
the
bugfix/failed_unittests
branch
from
eacf74c to
25979fe
Compare
|
It's fixed by d5b3a89 Thanks for your contribution though. |
|
@anencore94 Could you resolve conflicts to see if the new tests are covered or not? |
- Fix for Unit Test Failures
anencore94
force-pushed
the
bugfix/failed_unittests
branch
from
25979fe to
8772b3d
Compare
Thanks for the suggestion. PTAL @hangfei |
|
@anencore94 one of the test failed. Could you take a look? |
|
@hangfei Thanks for checking. I fixed the issue and tested in local. Is there any way to trigger the unit test action? https://github.com/google/adk-python/actions/runs/14928802444 |
|
@hangfei Please trigger the unit test action. Thanks in advance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #542
This commit fixes failed unit tests on "tests/unittests/tools/application_integration_tool/clients/test_connections_client.py"
and add another test cases for changed interface "test_get_connection_details_without_name"
Notes
These changes do not affect the main logic or features, but ensure consistency and reliability of the test suite.
Please let me know if you have any questions or need further adjustments.