Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: have backpack hide scrollbars when flyout opens #1842

Merged
merged 3 commits into from
Aug 21, 2023

Conversation

BeksOmega
Copy link
Contributor

Fixes #1841

Testing

Opened and closed the backpack and observed that scrollbars where hidden and shown.

Additional Info

Dependent on v10.1

@BeksOmega BeksOmega marked this pull request as ready for review August 14, 2023 16:04
@BeksOmega BeksOmega requested a review from a team as a code owner August 14, 2023 16:04
@BeksOmega BeksOmega requested review from NeilFraser and removed request for a team August 14, 2023 16:04
@BeksOmega
Copy link
Contributor Author

@maribethb I need to make this dependent on ^10.1.0 do you think that's worth doing a breaking change for (I kinda don't)? I can also just check if setVisible exists before calling it. That makes this backwards compatible with v10.

@BeksOmega BeksOmega removed the request for review from NeilFraser August 17, 2023 19:56
@BeksOmega
Copy link
Contributor Author

@maribethb I need to make this dependent on ^10.1.0 do you think that's worth doing a breaking change for (I kinda don't)? I can also just check if setVisible exists before calling it. That makes this backwards compatible with v10.

I decided to add a check for setVisible

@maribethb
Copy link
Contributor

@maribethb I need to make this dependent on ^10.1.0 do you think that's worth doing a breaking change for (I kinda don't)? I can also just check if setVisible exists before calling it. That makes this backwards compatible with v10.

I think adding the check to make it backwards compatible is best option. Otherwise, yeah, it would have to be a breaking change, otherwise npm might update the plugin automatically to an incompatible version :/

@BeksOmega BeksOmega merged commit b5f6f0b into google:master Aug 21, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have the backpack hide the workspace's scrollbars when the flyout opens
4 participants