Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vulkan: fix subpass validation #6980

Merged
merged 3 commits into from
Jul 25, 2023
Merged

vulkan: fix subpass validation #6980

merged 3 commits into from
Jul 25, 2023

Commits on Jul 21, 2023

  1. vulkan: fix subpass validation

     - Before, we supposed that the maximum number of input attachment
       should match the maximum number of color attachments. But in
       reality, we've only used one input attachment for the second
       subpass.
     - The problem with the above supposition is that the descriptor
       set layout for the input attachment descriptor set must have the
       exact number of input attachment specified in the shader. If the
       *layout* has more input attachment slots than specified in the
       shader, then we'd run into a validation error.
     - In this patch, we fix the number of max input attachment in
       the descriptor set layout to 1, since we ever only make use of
       one.
    
    Fixes #6513
    poweifeng committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    ceaa88a View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. Configuration menu
    Copy the full SHA
    23c48f7 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Configuration menu
    Copy the full SHA
    2de0fd5 View commit details
    Browse the repository at this point in the history