Feat: Added Support for CloudTrace Resource #307
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
aryanagrawal22
changed the title
mshudrak
reviewed
Dec 13, 2023
test/cloud_traces
Outdated
| @@ -0,0 +1 @@ | |||
| [] | |||
There was a problem hiding this comment.
Before diving into the review. Could you please provide an example output here for testing?
There was a problem hiding this comment.
Sure, I have added tests and made a minor change to an error. Please let me know any further changes.
mshudrak
requested changes
Jan 24, 2024
| #!/bin/bash | ||
|
|
||
| # Enable the CloudTrace API | ||
| gcloud services enable cloudtrace.googleapis.com |
There was a problem hiding this comment.
Well, it is not enough to generate a good test, right? You need to create this trace too to have it in the output of the tool. Could you provide an example on how to do it via bash?
| @@ -55,6 +55,9 @@ | |||
| "cloud_functions": { | |||
| "fetch": true | |||
| }, | |||
| "cloud_traces":{ | |||
|
Closing this one due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue #247 Added support for CloudTrace resource
Changes Made
Testing
Tested the resource locally. Ran Successfully.