-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Added Support for CloudTrace Resource #307
Closed
aryanagrawal22
wants to merge
2
commits into
google:main
from
aryanagrawal22:feat/247/cloud-trace-crawler
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
# Copyright 2023 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# https://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
|
||
from googleapiclient import discovery | ||
from httplib2 import Credentials | ||
|
||
from .interface_client import IClient | ||
|
||
|
||
class CloudTraceClient(IClient): | ||
"""CloudTraceClient class.""" | ||
|
||
def get_service(self, credentials: Credentials) -> discovery.Resource: | ||
"""Get discovery service for cloud trace resource. | ||
|
||
Args: | ||
credentials: An google.oauth2.credentials.Credentials object. | ||
|
||
Returns: | ||
An object of discovery.Resource | ||
""" | ||
return discovery.build( | ||
'cloudtrace', | ||
'v1', | ||
credentials=credentials, | ||
cache_discovery=False, | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
# Copyright 2023 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# https://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
import logging | ||
import sys | ||
from typing import Dict, Any, Union | ||
|
||
from googleapiclient import discovery | ||
|
||
from gcp_scanner.crawler.interface_crawler import ICrawler | ||
|
||
|
||
class CloudTraceCrawler(ICrawler): | ||
'''Handle crawling of Cloud Trace data.''' | ||
|
||
def crawl(self, project_id: str, service: discovery.Resource, | ||
config: Dict[str, Union[bool, str]] = None) -> Dict[str, Any]: | ||
'''Retrieve a list of Cloud Trace available in the project. | ||
|
||
Args: | ||
project_id: A name of a project to query info about. | ||
service: A resource object for interacting with the Cloud Trace API. | ||
config: Configuration options for the crawler (Optional). | ||
|
||
Returns: | ||
A list of resource objects representing the crawled data. | ||
''' | ||
|
||
logging.info("Retrieving CloudTrace") | ||
trace_list = list() | ||
try: | ||
request = service.projects().traces().list(projectId=project_id) | ||
while request is not None: | ||
response = request.execute() | ||
trace_list.extend(response.get("traces", [])) | ||
request = service.projects().traces().list_next( | ||
previous_request=request, previous_response=response) | ||
except Exception: | ||
logging.info("Failed to retrieve CloudTrace for project %s", project_id) | ||
logging.info(sys.exc_info()) | ||
return trace_list |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
#!/bin/bash | ||
|
||
# Enable the CloudTrace API | ||
gcloud services enable cloudtrace.googleapis.com | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well, it is not enough to generate a good test, right? You need to create this trace too to have it in the output of the tool. Could you provide an example on how to do it via bash? |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
[ | ||
{ | ||
CHECK "projectId": "cloud-trace-api", | ||
CHECK "traceId": "1a6942a2b3cb71dc20e3dbb7dc07c21f" | ||
} | ||
] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: missing space