Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blob/gcsblob: Use less-empty creds for unauthenticated mode. #3317

Merged
merged 1 commit into from
Sep 16, 2023

Conversation

vangent
Copy link
Contributor

@vangent vangent commented Sep 16, 2023

Fixes #3302.

@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Merging #3317 (a1f42cf) into master (62b022f) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3317      +/-   ##
==========================================
- Coverage   77.49%   77.45%   -0.05%     
==========================================
  Files         104      104              
  Lines       13923    13923              
==========================================
- Hits        10790    10784       -6     
- Misses       2373     2378       +5     
- Partials      760      761       +1     
Files Changed Coverage Δ
blob/gcsblob/gcsblob.go 87.90% <0.00%> (ø)

... and 2 files with indirect coverage changes

@vangent vangent merged commit 16a4757 into google:master Sep 16, 2023
6 checks passed
@vangent vangent deleted the noauth branch September 16, 2023 17:01
ybourgery pushed a commit to Simprints/go-cloud that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

blob/gcsblob: anonymous bucket access still requires default credentials
1 participant