Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blob/gcsblob: Use less-empty creds for unauthenticated mode. #3317

Merged
merged 1 commit into from
Sep 16, 2023
+1 −1
Merged

blob/gcsblob: Use less-empty creds for unauthenticated mode. #3317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion blob/gcsblob/gcsblob.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@
fmt.Printf("Warning: unable to load GCP Default Credentials: %v", err)
// Use empty credentials, in case the user isn't going to actually use
// them; e.g., getting signed URLs with GoogleAccessID=-.
creds = &google.Credentials{}
creds, _ = google.CredentialsFromJSON(ctx, []byte(`{"type": "service_account"}`))

Check warning on line 166 in blob/gcsblob/gcsblob.go

View check run for this annotation

Codecov / codecov/patch

blob/gcsblob/gcsblob.go#L166 

Added line #L166 was not covered by tests
}

// Populate default values from credentials files, where available.
Expand Down
Loading