blob/s3blob: Allow using s3ForcePathStyle as a synonym of use_path_style, for backwards compatibility with V1 #3505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yle, for backwards compatibility with V1
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3505 +/- ##
=======================================
Coverage 73.24% 73.25%
=======================================
Files 113 113
Lines 15051 15052 +1
=======================================
+ Hits 11024 11026 +2
+ Misses 3262 3261 -1
Partials 765 765 ☔ View full report in Codecov by Sentry. |
Kakulukian
pushed a commit
to OpenCNFT/nnn
that referenced
this pull request
Dec 5, 2024
The upgrade to GoCloud v0.39.0 switched to AWS SDK v2 and dropped support for the `s3ForcePathStyle` query parameter in the GoCloud URL. Even though GoCloud v0.40.0 brought `use_path_style`, the legacy `s3ForcePathStyle` parameter no longer worked with that version. This would cause `gitaly` to fail with an `unknown query parameter`. google/go-cloud#3505 adds back `s3ForcePathStyle` as an alias for `use_path_style` to preserve backwards compatibility. This commit bumps the version to a pseudo-ref that supports `s3ForcePathStyle`. Diff: https://github.com/google/go-cloud/compare/v0.40.0..56954848c3 Relates to https://gitlab.com/gitlab-org/gitaly/-/issues/6489 Changelog: fixed
Kakulukian
pushed a commit
to OpenCNFT/nnn
that referenced
this pull request
Dec 5, 2024
The upgrade to GoCloud v0.39.0 switched to AWS SDK v2 and dropped support for the `s3ForcePathStyle` query parameter in the GoCloud URL. Even though GoCloud v0.40.0 brought `use_path_style`, the legacy `s3ForcePathStyle` parameter no longer worked with that version. This would cause `gitaly` to fail with an `unknown query parameter`. google/go-cloud#3505 adds back `s3ForcePathStyle` as an alias for `use_path_style` to preserve backwards compatibility. This commit bumps the version to a pseudo-ref that supports `s3ForcePathStyle`. Diff: https://github.com/google/go-cloud/compare/v0.40.0..56954848c3 Relates to https://gitlab.com/gitlab-org/gitaly/-/issues/6489 Changelog: fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3472.