-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create npm workspace for E2E tests #10119
base: develop
Are you sure you want to change the base?
Conversation
Build files for 60b77c2 are ready:
|
Note the one failing E2E test will be fixed in #10111 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @benbowler. Nice work, but we need to move more dependencies. Please, see my comments.
"devDependencies": { | ||
"expect-puppeteer": "^4.4.0", | ||
"jest-puppeteer": "^4.4.0" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to define all dependencies that are used by e2e tests here, even if they are still used by other parts as well, in which case we shouldn't remove them from the main package.json.
Here is the full list of dependencies that should be here:
{
"dependencies": {
"@wordpress/babel-preset-default": "^4.20.0",
"@wordpress/e2e-test-utils": "^4.16.1",
"@wordpress/jest-console": "^3.10.0",
"amphtml-validator": "^1.0.38",
"babel-jest": "^26.6.3",
"dockerode": "^4.0.2",
"expect-puppeteer": "^4.4.0",
"jest": "^26.6.3",
"jest-puppeteer": "^4.4.0",
"jsdom": "^16.7.0",
"puppeteer": "^10.4.0"
}
}
"name": "googlesitekit-e2e", | ||
"description": "E2E testing infrastructure for Google Site Kit", | ||
"main": "script.js", | ||
"private": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed, we can remove it.
"name": "googlesitekit-e2e", | |
"description": "E2E testing infrastructure for Google Site Kit", | |
"main": "script.js", | |
"private": true, |
"repository": { | ||
"type": "git", | ||
"url": "git+https://github.com/google/site-kit-wp.git" | ||
}, | ||
"author": "Google", | ||
"license": "Apache-2.0", | ||
"bugs": { | ||
"url": "https://github.com/google/site-kit-wp/issues" | ||
}, | ||
"homepage": "https://github.com/google/site-kit-wp#readme" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same, not needed.
"repository": { | |
"type": "git", | |
"url": "git+https://github.com/google/site-kit-wp.git" | |
}, | |
"author": "Google", | |
"license": "Apache-2.0", | |
"bugs": { | |
"url": "https://github.com/google/site-kit-wp/issues" | |
}, | |
"homepage": "https://github.com/google/site-kit-wp#readme" |
"env:start": "./../../bin/local-env/start.sh", | ||
"env:stop": "./../../bin/local-env/stop.sh", | ||
"env:reset-site": "./../../bin/local-env/install-wordpress.sh --reset-site" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should also move local-env
files into the tests/e2e
folder? We don't use it anywhere else, right?
Summary
Addresses issue:
Relevant technical choices
puppeteer
andpuppeteer-core
are used in storybook tests currently, we should remove these from the main package.json as part of #10091.PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist