Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create npm workspace for E2E tests #10119

Merged
merged 36 commits into from
Feb 6, 2025
Merged
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
835fd58
Create E2E workspace and make scripts functional without any package …
benbowler Jan 24, 2025
f1eaef0
Update package-lock to npm version 7 format.
benbowler Jan 24, 2025
34a622a
Move E2E to npm workspace.
benbowler Jan 27, 2025
ddf20d9
Update npm version in e2e GitHub action.
benbowler Jan 27, 2025
3894782
Update npm version in e2e GitHub action.
benbowler Jan 27, 2025
60b77c2
Update npm version in JS lint GitHub action.
benbowler Jan 27, 2025
96aac9b
Apply suggestions from code review
benbowler Jan 31, 2025
b756ac7
Include dependencies shared with root package and e2e workspace.
benbowler Jan 31, 2025
846d233
Move local-env scripts to tests/e2e workspace.
benbowler Jan 31, 2025
054adf8
Update package-lock with nppm 7.
benbowler Feb 3, 2025
1a5bff0
Include other required packages in e2e/tests.
benbowler Feb 3, 2025
582f0ec
Fix paths in docker-compose and revert change in start.sh.
benbowler Feb 3, 2025
2912b48
Include npm v7 as dev dependency so developer don't need to install i…
benbowler Feb 3, 2025
4234514
Remove googlesitekit-e2e from deps.
aaemnnosttv Feb 3, 2025
762c366
Move jest-puppeteer config to workspace root.
aaemnnosttv Feb 3, 2025
2d0732d
Remove a few packages from root dev deps.
aaemnnosttv Feb 3, 2025
477444b
Update jest-puppeteer to version matching puppeteer.
aaemnnosttv Feb 3, 2025
f7b4b46
Update GH actions to use dev dependency version of npm.
benbowler Feb 4, 2025
8064c60
Revert shell script change and remove code comment.
benbowler Feb 4, 2025
f3b9a69
Update lint script to install workspace packages to fix unable to res…
benbowler Feb 4, 2025
8bf4eaf
Add npm v7 to workspace dev dependencies.
benbowler Feb 4, 2025
ed28fa2
Update package installation method.
benbowler Feb 4, 2025
7741226
Restore working base setup with global npm config.
benbowler Feb 4, 2025
226a0e1
Update local-env paths.
benbowler Feb 5, 2025
44664d8
Update workspace package.json to include all required packages and re…
benbowler Feb 5, 2025
5510bd8
Fix volume path to correctly load test plugins in Docker images.
benbowler Feb 5, 2025
1e4f326
Remove e2e packages in from the root packages.
benbowler Feb 5, 2025
d1a1de7
Revert to commit building in actions.
benbowler Feb 6, 2025
2d318a0
Revert to commit building in actions.
benbowler Feb 6, 2025
b19e8f8
Remove un-needed root dependency.
benbowler Feb 6, 2025
950e3e5
Remove un-needed root dependency.
benbowler Feb 6, 2025
7a26cb9
Remove un-needed root dependency.
benbowler Feb 6, 2025
5ff1a38
Remove un-needed root dependency.
benbowler Feb 6, 2025
94414d6
Revert "Remove un-needed root dependency."
benbowler Feb 6, 2025
d946f16
Remove un-needed root dependency.
benbowler Feb 6, 2025
b04f70b
Merge remote-tracking branch 'origin/develop' into infrastructure/100…
benbowler Feb 6, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update npm version in e2e GitHub action.
benbowler committed Jan 27, 2025
commit 3894782ac3eb9d1e54761531537cfc107fda7c15
10 changes: 5 additions & 5 deletions .github/workflows/e2e-tests.yml
Original file line number Diff line number Diff line change
@@ -101,6 +101,11 @@ jobs:
node-version-file: '.nvmrc'
cache: 'npm'

# nvm@7 is the minimum version required for npm workspace support.
# This can be removed once our node base version comes with nvm@7 or greater.
- name: Install npm v7
run: npm install -g [email protected]

- name: npm install
run: npm ci

@@ -128,11 +133,6 @@ jobs:
- name: Composer Install
run: composer install --no-interaction --no-progress --no-dev

# nvm@7 is the minimum version required for npm workspace support.
# This can be removed once our node base version comes with nvm@7 or greater.
- name: Install npm v7
run: npm install -g [email protected]

- name: Start environment
run: npm run env:start


Unchanged files with check annotations Beta

/**
* External dependencies
*/
import { setDefaultOptions } from 'expect-puppeteer';

Check failure on line 22 in tests/e2e/config/bootstrap.js

GitHub Actions / JS + CSS

Unable to resolve path to module 'expect-puppeteer'
import { get } from 'lodash';
import { ConsoleMessage } from 'puppeteer';
/**
* External dependencies
*/
import { getDefaultOptions } from 'expect-puppeteer';

Check failure on line 22 in tests/e2e/matchers/to-be-checked.js

GitHub Actions / JS + CSS

Unable to resolve path to module 'expect-puppeteer'
/**
* Asserts the given selector is checked.
/**
* External dependencies
*/
import { getDefaultOptions } from 'expect-puppeteer';

Check failure on line 22 in tests/e2e/matchers/to-have-tracking.js

GitHub Actions / JS + CSS

Unable to resolve path to module 'expect-puppeteer'
import { Page, ElementHandle } from 'puppeteer';
/**