Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: make node 18 the minimum version #2562

Merged
merged 19 commits into from
Dec 18, 2024
Merged

chore!: make node 18 the minimum version #2562

merged 19 commits into from
Dec 18, 2024

Conversation

thiyaguk09
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@thiyaguk09
Adds support for the restore token feature
6234521
@thiyaguk09
description fix
96a7664
@thiyaguk09
lint fix
912b32e
@thiyaguk09
Merge pull request #6 from thiyaguk09/support-for-restore-token
9b890f1 
feat: adds support for restore token
@thiyaguk09
Merge branch 'googleapis:main' into main
5ff35f0
@thiyaguk09
Merge branch 'googleapis:main' into support-for-restore-token
8c10e3d
@thiyaguk09
Merge pull request #7 from thiyaguk09/support-for-restore-token
a36d539 
Merge branch 'googleapis:main' into support-for-restore-token
@thiyaguk09
Merge branch 'googleapis:main' into main
fb4e87c
@thiyaguk09
Merge branch 'googleapis:main' into main
1a697c5
@thiyaguk09
Merge branch 'googleapis:main' into main
039b62d
@thiyaguk09
Merge pull request #9 from thiyaguk09/main
8d0e65d 
Node upgrade
@thiyaguk09
upgrade to node 18
1f78d9f 
upgrade to node 18
@thiyaguk09
lint fix phase 1
5e0a978 
lint fix phase 1
@thiyaguk09
lint fix phase 2
5769102 
lint fix phase 2
@thiyaguk09
bug fix
3c1b5de
@thiyaguk09
test case error fix
515c7ff
@thiyaguk09
test case error fix
258a38e
@thiyaguk09 thiyaguk09 requested review from a team as code owners December 9, 2024 15:03
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Dec 9, 2024
@generated-files-bot Generated Files Bot
Copy link

generated-files-bot bot commented Dec 9, 2024 •
edited
Loading

Warning: This pull request is touching the following templated files:

  • .kokoro/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/lint.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/samples-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/system-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node18/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node18/samples-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node18/system-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node18/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/release/docs-devsite.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/release/docs.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/release/publish.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/samples-test.sh - .kokoro files are templated and should be updated in synthtool
  • .kokoro/system-test.sh - .kokoro files are templated and should be updated in synthtool
  • .kokoro/test.sh - .kokoro files are templated and should be updated in synthtool
  • .github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool

@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Dec 9, 2024
ddelgrosso1
ddelgrosso1 requested changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@ddelgrosso1 ddelgrosso1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the files deleted under .kokoro/continuous/node14 we need to add back the same set of files for node 18.

@ddelgrosso1
Copy link
Contributor

Also need to update https://github.com/googleapis/nodejs-storage/tree/main/.kokoro/presubmit/node14

@thiyaguk09
chore: upgrade to Node 18
2af5598 
chore: upgrade to Node 18
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Dec 10, 2024
@thiyaguk09
Copy link
Contributor Author

For the files deleted under .kokoro/continuous/node14 we need to add back the same set of files for node 18.

All Kokoro-related files have been successfully upgraded to Node 18.

ddelgrosso1
ddelgrosso1 reviewed Dec 11, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@thiyaguk09
Removed unnecessary dependency.
f9dc145 
Removed unnecessary dependency.
@ddelgrosso1 ddelgrosso1 merged commit 1dc7657 into googleapis:node-18 Dec 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddelgrosso1 ddelgrosso1 ddelgrosso1 approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/nodejs-storage API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thiyaguk09 @ddelgrosso1