chore!: make node 18 the minimum version

.github/sync-repo-settings.yaml

@@ -14,9 +14,8 @@ branchProtectionRules:
       - "ci/kokoro: System test"
       - docs
       - lint
-      - test (14)
-      - test (16)
       - test (18)
+      - test (20)
       - cla/google
       - windows
       - OwlBot Post Processor

.github/workflows/ci.yaml

@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [14, 16, 18, 20]
+        node: [18, 20, 22]
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
@@ -32,7 +32,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 14
+          node-version: 18
       - run: npm install --engine-strict
       - run: npm test
         env:
@@ -43,7 +43,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 14
+          node-version: 18
       - run: npm install
       - run: npm run lint
   docs:
@@ -52,7 +52,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 14
+          node-version: 18
       - run: npm install
       - run: npm run docs
       - uses: JustinBeckwith/linkinator-action@v1

.github/workflows/conformance-test.yaml

@@ -11,7 +11,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: 14
+          node-version: 18
       - run: node --version
       - run: npm install
       - run: npm run conformance-test

conformance-test/conformanceCommon.ts

@@ -50,7 +50,7 @@ interface ConformanceTestResult {
 
 type LibraryMethodsModuleType = typeof import('./libraryMethods');
 const methodMap: Map<String, String[]> = new Map(
-  Object.entries(jsonToNodeApiMapping)
+  Object.entries(jsonToNodeApiMapping),
 );
 
 const DURATION_SECONDS = 600; // 10 mins.
@@ -94,36 +94,36 @@ export function executeScenario(testCase: RetryTestCase) {
             });
             creationResult = await createTestBenchRetryTest(
               instructionSet.instructions,
-              jsonMethod?.name.toString()
+              jsonMethod?.name.toString(),
             );
             if (storageMethodString.includes('InstancePrecondition')) {
               bucket = await createBucketForTest(
                 storage,
                 testCase.preconditionProvided,
-                storageMethodString
+                storageMethodString,
               );
               file = await createFileForTest(
                 testCase.preconditionProvided,
                 storageMethodString,
-                bucket
+                bucket,
               );
             } else {
               bucket = await createBucketForTest(
                 storage,
                 false,
-                storageMethodString
+                storageMethodString,
               );
               file = await createFileForTest(
                 false,
                 storageMethodString,
-                bucket
+                bucket,
               );
             }
             notification = bucket.notification(`${TESTS_PREFIX}`);
             await notification.create();
 
             [hmacKey] = await storage.createHmacKey(
-              `${TESTS_PREFIX}@email.com`
+              `${TESTS_PREFIX}@email.com`,
             );
 
             storage.interceptors.push({
@@ -154,7 +154,7 @@ export function executeScenario(testCase: RetryTestCase) {
               await assert.rejects(storageMethodObject(methodParameters));
             }
             const testBenchResult = await getTestBenchRetryTest(
-              creationResult.id
+              creationResult.id,
             );
             assert.strictEqual(testBenchResult.completed, true);
           }).timeout(TIMEOUT_FOR_INDIVIDUAL_TEST);
@@ -167,7 +167,7 @@ export function executeScenario(testCase: RetryTestCase) {
 async function createBucketForTest(
   storage: Storage,
   preconditionShouldBeOnInstance: boolean,
-  storageMethodString: String
+  storageMethodString: String,
 ) {
   const name = generateName(storageMethodString, 'bucket');
   const bucket = storage.bucket(name);
@@ -187,7 +187,7 @@ async function createBucketForTest(
 async function createFileForTest(
   preconditionShouldBeOnInstance: boolean,
   storageMethodString: String,
-  bucket: Bucket
+  bucket: Bucket,
 ) {
   const name = generateName(storageMethodString, 'file');
   const file = bucket.file(name);
@@ -209,7 +209,7 @@ function generateName(storageMethodString: String, bucketOrFile: string) {
 
 async function createTestBenchRetryTest(
   instructions: String[],
-  methodName: string
+  methodName: string,
 ): Promise<ConformanceTestCreationResult> {
   const requestBody = {instructions: {[methodName]: instructions}};
   const response = await fetch(`${TESTBENCH_HOST}retry_test`, {
@@ -221,7 +221,7 @@ async function createTestBenchRetryTest(
 }
 
 async function getTestBenchRetryTest(
-  testId: string
+  testId: string,
 ): Promise<ConformanceTestResult> {
   const response = await fetch(`${TESTBENCH_HOST}retry_test/${testId}`, {
     method: 'GET',

conformance-test/globalHooks.ts

@@ -29,7 +29,7 @@ export async function mochaGlobalSetup(this: any) {
   await getTestBenchDockerImage();
   await runTestBenchDockerImage();
   await new Promise(resolve =>
-    setTimeout(resolve, TIME_TO_WAIT_FOR_CONTAINER_READY)
+    setTimeout(resolve, TIME_TO_WAIT_FOR_CONTAINER_READY),
   );
 }