Feature/super expression #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The enabled JSOperations are: CallSuperConstructor, SetSuperProperty, GetSuperProperty, SetComputedSuperProperty, GetComputedSuperProperty, CallSuperMethod, UpdateSuperProperty
saelo
reviewed
Nov 15, 2024
| @@ -1633,7 +1633,7 @@ final class CallSuperConstructor: JsOperation { | |||
| } | |||
|
|
|||
| init(numArguments: Int) { | |||
| super.init(numInputs: numArguments, firstVariadicInput: 0, attributes: [.isVariadic, .isCall], requiredContext: [.javascript, .method]) | |||
| super.init(numInputs: numArguments, numOutputs: 1, firstVariadicInput: 0, attributes: [.isVariadic, .isCall], requiredContext: [.javascript, .method]) | |||
There was a problem hiding this comment.
Why this change? Do we need to handle the return value of this, or could we just convert it to this instead if we really need it? (AFAIK the return value will just be this)
| guard !callSuperConstructor.isOptional else { | ||
| throw CompilerError.unsupportedFeatureError("Optional chaining is not supported in super constructor calls") | ||
| } | ||
| return emit(CallSuperConstructor(numArguments: arguments.count), withInputs: arguments).output |
There was a problem hiding this comment.
Is this why you need CallSuperConstructor to now return a value? I wonder if we should just do this instead:
// The "return" value of invoking the super constructor is just |this|
emit(CallSuperConstructor(numArguments: arguments.count), withInputs: arguments)
return emit(LoadThis())
WDYT?
There was a problem hiding this comment.
Ah even simpler, I think you can just do return lookupIdentifier("this"); since this must be available inside class constructors/methods (see
saelo
reviewed
Nov 18, 2024
|
Nice, thanks! 🎉 |
parthdt
pushed a commit
to parthdt/fuzzilli
that referenced
this pull request
Dec 14, 2024
The enabled JSOperations are: CallSuperConstructor, SetSuperProperty, GetSuperProperty, SetComputedSuperProperty, GetComputedSuperProperty, CallSuperMethod, UpdateSuperProperty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, 7 new JSOperations become compilable:
I verified correctness with Tests/FuzzilliTests/CompilerTests/super.js
Lifts to semantically equivalent code. (No side effects like with delete).
It is probably not a lot of effort to implement the remaining super cases but it is lower down the priority list.