-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/super expression #468
Merged
saelo
merged 5 commits into
googleprojectzero:main
from
TobiasWienand:feature/super-expression
Nov 21, 2024
+407
−0
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f5eea4c
Implements Compilation of 7 Super Expression
TobiasWienand 72cbfe6
Testing of all 7 newly compilable super JSOperations
TobiasWienand 17395ed
Implements fix for return value of CallSuperConstructor
TobiasWienand a978939
Adds documentation to case ".callSuperConstructor"
TobiasWienand 3d48998
Merge remote-tracking branch 'origin/main' into feature/super-expression
TobiasWienand File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1633,7 +1633,7 @@ final class CallSuperConstructor: JsOperation { | |
} | ||
|
||
init(numArguments: Int) { | ||
super.init(numInputs: numArguments, firstVariadicInput: 0, attributes: [.isVariadic, .isCall], requiredContext: [.javascript, .method]) | ||
super.init(numInputs: numArguments, numOutputs: 1, firstVariadicInput: 0, attributes: [.isVariadic, .isCall], requiredContext: [.javascript, .method]) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why this change? Do we need to handle the return value of this, or could we just convert it to |
||
} | ||
} | ||
|
||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this why you need
CallSuperConstructor
to now return a value? I wonder if we should just do this instead:WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah even simpler, I think you can just do
return lookupIdentifier("this");
sincethis
must be available inside class constructors/methods (seefuzzilli/Sources/Fuzzilli/Compiler/Compiler.swift
Line 226 in 0f52182