Skip to content

Conversation

@Kangz
Copy link
Collaborator

@Kangz Kangz commented Nov 12, 2025

FYI @andyleiserson

Calling end() on an already ended or invalid pass should generate a device error. Detect these cases in pass_end_invalid_order and expect a validation error in these cases.

Passing locally after many other fixes for encoder error reporting in Dawn.

Issue: #


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@Kangz Kangz requested a review from kainino0x November 12, 2025 13:59
Calling end() on an already ended or invalid pass should generate a
device error. Detect these cases in pass_end_invalid_order and expect a
validation error in these cases.
@Kangz Kangz force-pushed the pass_end_invalid_order branch from ec5da58 to 39cf3f0 Compare November 12, 2025 14:05
@Kangz Kangz merged commit d6613a5 into gpuweb:main Nov 13, 2025
1 check passed
@Kangz Kangz deleted the pass_end_invalid_order branch November 13, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants