Ts types jenny tests #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 12, 2023
K-Phoen
force-pushed
the
inspect-command
branch
from
f57c544
to
f7d901b
Compare
K-Phoen
force-pushed
the
ts-types-jenny-tests
branch
from
161ede6
to
3af16d6
Compare
|
Do we want to use txtar files for testing? I'm not against that, I'm only curious. |
|
I quite like having the IR and all the code we can generate from it in one file + it's quite easy to add more test case for jennies. That's mainly why I went with txtar, but I don't have a strong opinion if that's not something we want to go with 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a bunch of test cases for the IR → Typescript raw types jenny.
I'm mostly happy with the current state of that jenny. The resulting Typescript seems to be good, even though a few things aren't supported:
This points ↑ can be addressed later. Merging this PR closes #5 and would allow us to focus either on #6 or TS builders generation.