Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky TestReusableGoroutinesPool test #596

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

julienduchesne
Copy link
Member

Fixes #593
Count goroutines from the current test rather than for the whole process

Fixes #593
Count goroutines from the current test rather than for the whole process
@julienduchesne
Copy link
Member Author

julienduchesne commented Oct 4, 2024

/find-flaky-tests

Edit: Workflow running here: https://github.com/grafana/dskit/actions/runs/11185557628

@julienduchesne julienduchesne changed the title Fix flaky Test flake TestReusableGoroutinesPool test Fix flaky TestReusableGoroutinesPool test Oct 4, 2024
@julienduchesne julienduchesne marked this pull request as ready for review October 4, 2024 19:08
@julienduchesne julienduchesne requested a review from a team October 4, 2024 19:08
Copy link
Contributor

@seizethedave seizethedave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@julienduchesne julienduchesne merged commit a711ce3 into main Oct 4, 2024
5 checks passed
@julienduchesne julienduchesne deleted the julienduchesne/fix-flaky-test branch October 4, 2024 23:52
julienduchesne added a commit that referenced this pull request Oct 8, 2024
It randomly failed here: #525 and in some of the test runs here: #596

This test fails due to the probe interval being 5s, which is the same time we poll for
julienduchesne added a commit that referenced this pull request Oct 8, 2024
It randomly failed here: #525 and in some of the test runs here: #596

This test fails due to the probe interval being 5s, which is the same time we poll for
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test flake TestReusableGoroutinesPool
2 participants