-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check_mode: false to Mirmir and Promtail "Scrape GitHub" Task" #266
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this was implemented in the Loki. Approved from my side.
This is missing: @x4e-jonas |
Sounds a bit invasive. I'm not into US laws. |
@x4e-jonas, since you chose not to sign the CLA, I have created a new PR: #267. In this PR, I made additional code changes to support check mode for Promtail and also included Loki. I have tested check mode for both Loki and Promtail in this updated PR. |
Since #267 has been merged, I believe the code needs to be adjusted. If other roles require check mode, they should be properly tested and implemented. As a result, Promtail and Loki can definitely be removed from this PR. |
Thanks |
The fix in #262 missed Mimir and Promtail.