Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check_mode: false to Mirmir and Promtail "Scrape GitHub" Task" #266

Closed
wants to merge 2 commits into from

Conversation

x4e-jonas
Copy link

The fix in #262 missed Mimir and Promtail.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

voidquark
voidquark previously approved these changes Sep 10, 2024
Copy link
Collaborator

@voidquark voidquark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this was implemented in the Loki. Approved from my side.

@voidquark
Copy link
Collaborator

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

This is missing: @x4e-jonas

@x4e-jonas
Copy link
Author

This is missing: @x4e-jonas

Sounds a bit invasive. I'm not into US laws.
Is this really required for such small changes? Feel free to takeover the patches as public domain.

@voidquark
Copy link
Collaborator

@x4e-jonas, since you chose not to sign the CLA, I have created a new PR: #267. In this PR, I made additional code changes to support check mode for Promtail and also included Loki. I have tested check mode for both Loki and Promtail in this updated PR.

@voidquark
Copy link
Collaborator

Since #267 has been merged, I believe the code needs to be adjusted. If other roles require check mode, they should be properly tested and implemented. As a result, Promtail and Loki can definitely be removed from this PR.

@x4e-jonas
Copy link
Author

Thanks

@x4e-jonas x4e-jonas closed this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants