Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: promtail and loki check mode #267

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Conversation

voidquark
Copy link
Collaborator

Why this PR?

The original PR #266 appears to be on hold, due to not signing the Contributor License Agreement (CLA). Additionally, it seems to be lacking some necessary changes for Loki and Promtail.

What Does This PR Change?

I tested Promtail and Loki in check mode and verified that it works on fresh systems where neither Loki nor Promtail is installed. This PR ensures that you can run check mode for both Promtail and Loki.

@voidquark
Copy link
Collaborator Author

@ishanjainn, could you please review this when you have a moment? Thank you! 🚀

@voidquark voidquark changed the title Fix/promtail loki check mode Fix: promtail and loki check mode Sep 11, 2024
@ishanjainn ishanjainn merged commit d93e1b1 into main Sep 13, 2024
14 of 19 checks passed
@ishanjainn ishanjainn deleted the fix/promtail_loki_check_mode branch September 13, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants