-
Notifications
You must be signed in to change notification settings - Fork 297
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Loading status checks…
Show info about missing users in schedules (#4294)
# What this PR does - Don't show global notification if one of the rolling_users is a user that doesn't exist anymore (has been deleted) - In case user present in rolling_users has been either deleted or his/her role has been downgraded to Viewer, show such explicit info on UI ![image](https://github.com/grafana/oncall/assets/12073649/45cec62d-b62b-4085-b536-906ef9dbef1f) ![image](https://github.com/grafana/oncall/assets/12073649/692dea50-10c7-47e9-9371-565e21d80cfe) ## Which issue(s) this PR closes Closes #4251 <!-- *Note*: if you have more than one GitHub issue that this PR closes, be sure to preface each issue link with a [closing keyword](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue). This ensures that the issue(s) are auto-closed once the PR has been merged. --> ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] Added the relevant release notes label (see labels prefixed w/ `release:`). These labels dictate how your PR will show up in the autogenerated release notes.
- v1.14.1
- v1.14.0
- v1.13.11
- v1.13.10
- v1.13.9
- v1.13.8
- v1.13.7
- v1.13.6
- v1.13.5
- v1.13.4
- v1.13.3
- v1.13.2
- v1.13.1
- v1.13.0
- v1.12.1
- v1.12.0
- v1.11.5
- v1.11.4
- v1.11.3
- v1.11.2
- v1.11.1
- v1.11.0
- v1.10.6
- v1.10.5
- v1.10.4
- v1.10.3
- v1.10.2
- v1.10.1
- v1.10.0
- v1.9.31
- v1.9.30
- v1.9.29
- v1.9.28
- v1.9.27
- v1.9.26
- v1.9.25
- v1.9.24
- v1.9.23
- v1.9.22
- v1.9.21
- v1.9.20
- v1.9.19
- v1.9.18
- v1.9.17
- v1.9.16
- v1.9.15
- v1.9.14
- v1.9.13
- v1.9.12
- v1.9.11
- v1.9.10
- v1.9.9
- v1.9.8
- v1.9.7
- v1.9.6
- v1.9.5
- v1.9.4
- v1.9.3
- v1.9.2
- v1.9.1
- v1.9.0
- v1.8.13
- v1.8.12
- v1.8.11
- v1.8.10
- v1.8.9
- v1.8.8
- v1.8.7
- v1.8.6
- v1.8.5
- v1.8.4
- v1.8.3
- v1.8.2
- v1.8.1
- v1.8.0
- v1.7.2
- v1.7.1
- v1.7.0
- v1.6.2
- v1.6.1
- v1.6.0
- v1.5.5
- v1.5.4
- v1.5.3
- v1.5.2
- v1.5.1
- v1.5.0
- v1.4.7
- v1.4.6
- v1.4.5
- oncall-1.14.1
- oncall-1.14.0
- oncall-1.13.11
- oncall-1.13.10
- oncall-1.13.9
- oncall-1.13.8
- oncall-1.13.7
- oncall-1.13.6
- oncall-1.13.5
- oncall-1.13.4
- oncall-1.13.3
- oncall-1.13.2
- oncall-1.13.1
- oncall-1.13.0
- oncall-1.12.1
- oncall-1.12.0
- oncall-1.11.5
- oncall-1.11.3
- oncall-1.11.2
- oncall-1.11.1
- oncall-1.11.0
- oncall-1.10.6
- oncall-1.10.5
- oncall-1.10.4
- oncall-1.10.3
- oncall-1.10.2
- oncall-1.10.1
- oncall-1.10.0
- oncall-1.9.31
- oncall-1.9.30
- oncall-1.9.29
- oncall-1.9.25
- oncall-1.9.24
- oncall-1.9.23
- oncall-1.9.22
- oncall-1.9.21
- oncall-1.9.20
- oncall-1.9.19
- oncall-1.9.18
- oncall-1.9.17
- oncall-1.9.16
- oncall-1.9.15
- oncall-1.9.13
- oncall-1.9.12
- oncall-1.9.11
- oncall-1.9.10
- oncall-1.9.9
- oncall-1.9.8
- oncall-1.9.7
- oncall-1.9.6
- oncall-1.9.5
- oncall-1.9.4
- oncall-1.9.3
- oncall-1.9.2
- oncall-1.9.1
- oncall-1.9.0
- oncall-1.8.13
- oncall-1.8.12
- oncall-1.8.11
- oncall-1.8.10
- oncall-1.8.9
- oncall-1.8.8
- oncall-1.8.7
- oncall-1.8.6
- oncall-1.8.5
- oncall-1.8.4
- oncall-1.8.3
- oncall-1.8.2
- oncall-1.8.1
- oncall-1.8.0
- oncall-1.7.2
- oncall-1.7.1
- oncall-1.6.2
- oncall-1.6.1
- oncall-1.6.0
- oncall-1.5.5
- oncall-1.5.4
- oncall-1.5.3
- oncall-1.5.1
- oncall-1.5.0
- oncall-1.4.7
- oncall-1.4.6
- oncall-1.4.5
Showing
6 changed files
with
66 additions
and
17 deletions.
There are no files selected for viewing
19 changes: 19 additions & 0 deletions
19
grafana-plugin/src/components/NonExistentUserName/NonExistentUserName.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
import React, { ComponentProps, FC } from 'react'; | ||
|
||
import { HorizontalGroup, Icon, Tooltip } from '@grafana/ui'; | ||
|
||
interface NonExistentUserNameProps { | ||
justify?: ComponentProps<typeof HorizontalGroup>['justify']; | ||
userName?: string; | ||
} | ||
|
||
const NonExistentUserName: FC<NonExistentUserNameProps> = ({ justify = 'space-between', userName }) => ( | ||
<HorizontalGroup justify={justify}> | ||
<span>Missing user</span> | ||
<Tooltip content={`${userName || 'User'} } is not found or doesn't have permission to participate in the rotation`}> | ||
<Icon name="exclamation-triangle" /> | ||
</Tooltip> | ||
</HorizontalGroup> | ||
); | ||
|
||
export default NonExistentUserName; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters